WordPress.org

Make WordPress Core

Opened 7 weeks ago

Last modified 6 weeks ago

#48343 new defect (bug)

$args documentation for WP_Customize_Control::__construct() and WP_Customize_Manager::add_control() don't match

Reported by: marekdedic Owned by:
Milestone: 5.4 Priority: normal
Severity: minor Version: 5.3
Component: Customize Keywords: good-first-bug has-patch 2nd-opinion
Focuses: docs Cc:
PR Number:

Description

I believe the $args parameter should be the same for both methods, given how add_control() just calls the constructor.

https://developer.wordpress.org/reference/classes/wp_customize_control/__construct/

https://developer.wordpress.org/reference/classes/wp_customize_manager/add_control/

Attachments (1)

48343.diff (4.7 KB) - added by hAmpzter 6 weeks ago.
Updated WP_Customize_Manager::add_control args-documentation to be equal to WP_Customize_Control::construct

Download all attachments as: .zip

Change History (4)

#1 @desrosj
7 weeks ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to 5.4

This ticket was mentioned in Slack in #core by sergey. View the logs.


6 weeks ago

@hAmpzter
6 weeks ago

Updated WP_Customize_Manager::add_control args-documentation to be equal to WP_Customize_Control::construct

#3 @hAmpzter
6 weeks ago

  • Keywords has-patch 2nd-opinion added; needs-patch removed
Note: See TracTickets for help on using tickets.