Update notification i18n improvements

[nbachiyski]

• Split into more translatable phrases
• Allow translators to change the urls in the footer, documentation and feedback forums can be different for local versions

[Viper007Bond]

Not sure if I like localizations of WordPress being able to change the URLs in the footer. What's to say one unofficial WP support site is better than the other?

ex: say there are two Italian WordPress support sites. Who's to pick which is the better and which should be linked to in the official Italian translation?

[leonid]

Those people who do WordPress support for their clients might want to use a different URL (ticketing system/local forum), or remove it altogether. The easier it is to change, the better.

[ryan]

(In [5955]) Gettext fixes from nbachiyski. fixes #4835

[Viper007Bond]

Replying to leonid:

Those people who do WordPress support for their clients might want to use a different URL (ticketing system/local forum), or remove it altogether. The easier it is to change, the better.

Then that would be the purpose of a filter, not localization.

[Viper007Bond]

I hate to be a pest, but I still think is a bad patch in terms of the URLs.

If we need to update these URLs later (say the support forums), we would need to generate whole new strings for translation. If the translator feels they need to change all of the URLs for some reason, then they can simple replace the %s' with URLs with no ill effects. Not to mention it's just bad form IMO.

Or is there something I'm missing? I'm the first to admit that I'm no i18n expert.

[nbachiyski]

Yes, if they replace an %s with the string they want will happily work in PHP, but the gettext tools won't allow you to compile a mo file if you have skipped a format specifier -- it is considered a syntax error.

[Viper007Bond]

Gotcha.