Opened 6 years ago
Closed 6 years ago
#48350 closed task (blessed) (fixed)
Stricter docs for WP_Http::processHeaders()
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 5.5 | Priority: | normal |
| Severity: | minor | Version: | 5.2 |
| Component: | HTTP API | Keywords: | good-first-bug has-patch |
| Focuses: | docs | Cc: |
Description
I believe the function could better document the parameter and return types. From a look at the source, maybe something like this:
@param string|string[] $headers
@param string $url
@return array {
@type array $response {
@type int $code
@type string $message
}
@type string|string[] $newheaders
@type WP_Http_Cookie[] $cookies
}
+ comments obviously.
Attachments (4)
Change History (16)
This ticket was mentioned in Slack in #core by david.baumwald. View the logs.
6 years ago
#7
@
6 years ago
- Keywords needs-refresh added
- Milestone changed from 5.4 to Future Release
The most recent patch fails against trunk. This ticket still needs a refreshed patch, and with 5.4 Beta 1 landing tomorrow, this is being moved to Future Release. If any maintainer or committer feels this can be included in 5.4 or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.
This ticket was mentioned in Slack in #core by david.baumwald. View the logs.
6 years ago
Note: See
TracTickets for help on using
tickets.
Heya!
Attached a file containing expanded documentation for
processHeaders().Looking forward to any feedback!