Update sodium_compat to v1.12.1

[paragoninitiativeenterprises]

​https://github.com/paragonie/sodium_compat/releases/tag/v1.12.0

paragonie/sodium_compat 1.12.0 includes a speedup for signature verification on most platforms (and bugfixes for PHP 5.2 and 32-bit platforms), so it might be worth including in the next minor release of WordPress.

I can supply a patch against trunk if that will be helpful.

[pierlo]

Hi @paragoninitiativeenterprises, a patch would be great to get this ticket moving.

[paragoninitiativeenterprises]

sodium_compat v1.12.0

[paragoninitiativeenterprises]

Patch supplied

[lukaswaudentio]

It appears there is an incompatibility between the version currently deployed by WordPress 5.2.4 and the latest version of the library, causing WordPress to crash if another source attempts to load the latest version. An update of the library would be strongly appreciated.

Not sure if I'm encouraged to change properties here, but I would love to classify this as bug with a severity of at least major.

[paragoninitiativeenterprises]

Update to version 1.12.1

[paragoninitiativeenterprises]

This should be ready to be tested/reviewed for the next WordPress release.

[pierlo]

Hey @dd32 or @tellyworth could I get a quick review on this? Tagging you all since you are more familiar with the library.

[SergeyBiryukov]

In 46858:

Upgrade/Install: Update sodium_compat to v1.12.1.

This includes a speedup for signature verification on most platforms and bugfixes for 32-bit platforms.

Props paragoninitiativeenterprises, lukaswaudentio.
Fixes #48371.

[SergeyBiryukov]

In 46859:

Upgrade/Install: Update sodium_compat to v1.12.1.

This includes a speedup for signature verification on most platforms and bugfixes for 32-bit platforms.

Props paragoninitiativeenterprises, lukaswaudentio.
Merges [46858] to the 5.3 branch.
Fixes #48371.