WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#48390 closed defect (bug) (wontfix)

Improve the Servehappy dashboard notice wording

Reported by: desrosj's profile desrosj Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.1
Component: Site Health Keywords: has-screenshots
Focuses: Cc:

Description

The PHP update nag in the dashboard helps alert users that their site is running an insecure version of PHP and instructs them to update to a newer, supported version.

There are a few things missing from this notice, though:

  • What version of PHP is the site actually running?
  • What version should you be running?
  • A link to Site Health for more information.
  • A suggested message a user could use when contacting their hosting company.

Also, the primary call to action for most users to resolve this issue is missing: contact your hosting company.

While hosts can add their own update button by defining the WP_DIRECT_UPDATE_PHP_URL environment variable or using the wp_direct_php_update_url filter, the user should be pointed in the direction of contacting their host if these are not present.

Previously: #45686.

Attachments (1)

Screen Shot 2019-10-19 at 7.06.34 PM.png​ (89.3 KB) - added by desrosj 5 years ago.

Download all attachments as: .zip

Change History (12)

@desrosj
5 years ago

#2 @Clorith
5 years ago

I could swear we had a discussion about showing versions numbers, but I'm unable to find back to it right now unfortunately.

My take on it is that version numbers mean little to nothing to the average user, and only lead to it becoming perceived as more of a "technical hurdle" when presented to those who may be unfamiliar with it. (I could be wrong of course, this is why we have discussions about it after all :) )

Creating a call to action button to contact their host is not really possible, unless the host uses the filters you mentioned, WordPress has no way of knowing who the host is, or what the appropriate contact channels are.

The notice does link to the ​Update PHP page, which has information about contacting their host, including an example message they could send.

For the sake of completeness, what does a PHP notice with version strings look like in your ideal scenario?

#3 @Clorith
5 years ago

I totally missed the part about the Site Health link, I think that's not a bad idea, something along the lines of a link under the call to action button(s) sounding a bit like Learn more about the overall health of your site linking to the site health page?

This ticket was mentioned in ​Slack in #core-site-health by mi5t4n. ​View the logs.
5 years ago

#5 @afragen
5 years ago

I would tend to agree with @Clorith here. I don't believe this level of detail is needed in the dashboard nag, but detail would be beneficial in the Site Health page.

This ticket was mentioned in ​Slack in #core-site-health by afragen. ​View the logs.
5 years ago

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
5 years ago

#8 @audrasjb
5 years ago

  • Keywords needs-patch added
  • Milestone changed from 5.3.1 to 5.4

Given it's more like a small enhancement, and as 5.3.1 will be focused on 5.3 regression, I'm punting it to the next major so it could be quietly discussed and patched.

This ticket was mentioned in ​Slack in #core-site-health by clorith. ​View the logs.
5 years ago

#11 @Clorith
5 years ago

  • Keywords needs-patch removed
  • Milestone 5.4 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

With the introduction of the Site Health dashboard widget in r47063, this feels like it may be too much information, and it's now easier for the user to click through and find these details them selves.

With that in mind I'm closing this ticket for now, but it is always open for further discussion down the line.

Note: See TracTickets for help on using tickets.