Media modal: the inline uploader visual order doesn't match the source order

[afercia]

In the Media modal dialog, when a search doesn't return results, the so called "inline uploader" appears with a message: "No items found. Drop files to upload" and the UI to upload new files.

The inline uploader UI appears after the toolbar with the search but it's actually placed before it in the source.

This is extremely confusing for keyboard users and assistive technologies users, as tabbing through the content happens with a illogical, counterintuitive order.

See attached screenshots.

To see the inline uploader:

• from Gutenberg: insert an image block
• click Media Library
• within the modal, do a search that doesn't return results
• see the inline uploader appears
• use the Tab key to navigate through the modal elements
• see the tab order is confusing

Same for the Classic editor: just click Add Media and do a search that doesn't return results.

Not sure there are technical reasons why the inline uploader is placed in the source out of a logical order. worth exploring and fixing the order.

[syhc]

Here is a patch to solution, my solution is to reorder the two functions calls in browser.js

​https://streamable.com/azg1j

[audrasjb]

Media: Accessibility: Move the inline uploader right after the toolbar to ensure the media modal visual order matches the source order.

[audrasjb]

48403.1.diff

[audrasjb]

In 48403.1.diff:

Media: Accessibility: Move the inline uploader right after the toolbar to ensure the media modal visual order matches the source order.

The patch also updates inline comments and adds a reference to this ticket.

It's good to go on my side (see animated screenshot above).

[afercia]

Reviewing 48403.1.diff​.

While it fixes the issue in the media modal, it would revert back the change from #37188 thus re-introducing the original issue in the media library. That is, on the admin page /wp-admin/upload.php?mode=grid the "Add New" button should be immediately followed by the uploader.

A more proper fix should differentiate the two cases and place the uploader before in the media modal, and keep it after in the media grid.

[afercia]

48403.2.diff​ checks for the grid mode (the Media Library) and swaps the Toolbar / Uploader order conditionally.

[afercia]

In 47217:

Accessibility: Media: Make the toolbar and inline uploader visual order always match the DOM order.

Depending on the specific media view, the media UI elements are placed in a
different visual order. This change makes sure their visual order always
matches the DOM order.

Propos syhc, audrasjb, afercia.
See #37188.
Fixes #48403.