WordPress.org

Make WordPress Core

Opened 4 weeks ago

Last modified 2 weeks ago

#48403 assigned defect (bug)

Media modal: the inline uploader visual order doesn't match the source order

Reported by: afercia Owned by: afercia
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-screenshots has-patch
Focuses: ui, accessibility, javascript Cc:
PR Number:

Description

In the Media modal dialog, when a search doesn't return results, the so called "inline uploader" appears with a message: "No items found. Drop files to upload" and the UI to upload new files.

The inline uploader UI appears after the toolbar with the search but it's actually placed before it in the source.

This is extremely confusing for keyboard users and assistive technologies users, as tabbing through the content happens with a illogical, counterintuitive order.

See attached screenshots.

To see the inline uploader:

  • from Gutenberg: insert an image block
  • click Media Library
  • within the modal, do a search that doesn't return results
  • see the inline uploader appears
  • use the Tab key to navigate through the modal elements
  • see the tab order is confusing

Same for the Classic editor: just click Add Media and do a search that doesn't return results.

Not sure there are technical reasons why the inline uploader is placed in the source out of a logical order. worth exploring and fixing the order.

Attachments (3)

media inline uploader 01.png (84.9 KB) - added by afercia 4 weeks ago.
media inline uploader 02.png (99.8 KB) - added by afercia 4 weeks ago.
48403.diff (1.2 KB) - added by syhc 2 weeks ago.

Download all attachments as: .zip

Change History (10)

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


3 weeks ago

#2 @afercia
3 weeks ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.4

#3 @afercia
3 weeks ago

  • Owner set to afercia
  • Status changed from new to assigned

This ticket was mentioned in Slack in #accessibility by nrqsnchz. View the logs.


2 weeks ago

This ticket was mentioned in Slack in #accessibility by syhc. View the logs.


2 weeks ago

@syhc
2 weeks ago

#6 @syhc
2 weeks ago

  • Keywords has-patch added; needs-patch removed

Here is a patch to solution, my solution is to reorder the two functions calls in browser.js

https://streamable.com/azg1j

Last edited 2 weeks ago by syhc (previous) (diff)

This ticket was mentioned in Slack in #accessibility by syhc. View the logs.


2 weeks ago

Note: See TracTickets for help on using tickets.