WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 7 months ago

#48417 closed enhancement (fixed)

Change text wordpress to WordPress

Reported by: 1naveengiri Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.3
Component: General Keywords: has-patch
Focuses: docs, coding-standards Cc:

Description

So far everything is done to convert "Wordpress" or "wordpress" to "WordPress" after capital_P_dangit().

I have noticed a few lines in a code comment. where we are still using small case "wordpress".
so I am wondering. it will be good to convert it to "WordPress".

Thanks

Attachments (4)

Screen Shot 2019-10-24 at 8.58.58 AM.png (107.2 KB) - added by 1naveengiri 7 months ago.
Screen Shot 2019-10-24 at 8.58.44 AM.png (93.2 KB) - added by 1naveengiri 7 months ago.
48417.patch (2.4 KB) - added by Marcio Zebedeu 7 months ago.
made the change from wordpress to WordPress
48417.1.diff (537 bytes) - added by Hareesh Pillai 7 months ago.
Updated patch

Download all attachments as: .zip

Change History (7)

@Marcio Zebedeu
7 months ago

made the change from wordpress to WordPress

#1 @SergeyBiryukov
7 months ago

  • Keywords has-patch added; 2nd-opinion removed
  • Milestone changed from Awaiting Review to 5.4
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

Hi there, thanks for the ticket and the patch!

The change in wp-admin/css/customize-widgets.css looks good. Note that there's no need to patch RTL CSS files, as they are automatically generated during the build process.

The change in wp-includes/css/dist/edit-post/style.css should be submitted upstream, as edit-post is an external package developed on GitHub.

@Hareesh Pillai
7 months ago

Updated patch

#2 @SergeyBiryukov
7 months ago

Upon a closer look, wordpress here is a Dashicon slug reference and should not be capitalized.

That said, there are a couple of inconsistencies between these comments and actual Dashicons, let's fix them for clarity.

#3 @SergeyBiryukov
7 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 46681:

Docs: Correct some inconsistencies in comments with Dashicon class references in wp-admin/css/customize-widgets.css.

Prepend all class name references with dashicons- for clarity.

Props 1naveengiri, marcio-zebedeu, hareesh-pillai, SergeyBiryukov.
Fixes #48417.

Note: See TracTickets for help on using tickets.