Changes between Version 3 and Version 4 of Ticket #48420, comment 24
- Timestamp:
- 11/27/2019 07:38:45 PM (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #48420, comment 24
v3 v4 1 1 Related: #48531. 2 2 3 Quick look at 48420.2.diff and similar changes that were committed in 5.3: Generally converting existing values from "hard coded" `px` to "dynamic" `rem`, `%`, etc. is a good idea and seems "safe enough" to do. However changing these values at the same time is not a good idea and is not "safe to do" especially in a dot release :)3 Quick look at 48420.2.diff and similar changes that were committed in 5.3: Generally converting existing values from "hard coded" `px` to "dynamic" `rem`, `%`, unitless line-height, etc. is a good idea and seems "safe enough" to do. However changing these values at the same time is not a good idea and is not "safe to do" especially in a dot release :) 4 4 5 5 Ideally the conversion should happen first, be committed, (thoroughly) tested in all browsers and eventually refined and fixed if needed.