Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#48424 closed enhancement (fixed)

Add a comment to RTL files for new contributors, take 2

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch commit
Focuses: docs Cc:


Background: #30666

[41271] added a comment to minified files explaining that they are auto-generated, to help reduce some confusion for new contributors:

/*! This file is auto-generated */

The same should be done for RTL files, since they are also auto-generated during the build process, and should not be patched directly.

Attachments (1)

48424.diff (983 bytes) - added by SergeyBiryukov 5 years ago.

Download all attachments as: .zip

Change History (4)

#1 follow-up: @swissspidy
5 years ago

Is there a ticket for doing the same for JS files? Occasionally people try to fix things in minified Gutenberg scripts in core.

5 years ago

#2 in reply to: ↑ 1 @SergeyBiryukov
5 years ago

  • Keywords has-patch commit added

Replying to swissspidy:

Is there a ticket for doing the same for JS files?

Not that I know of, let's do it here :) 48424.diff should cover both JS and RTL CSS files.

#3 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 46589:

Build/Test Tools: Add banner to RTL CSS and minified JS files.

Patches occasionally come in on generated files. We should be kind to new contributors and give them a hint that these files are auto-generated.

This is a follow-up to [41271], which added the banner to minified CSS files.

Fixes #48424. See #30666.

Note: See TracTickets for help on using tickets.