Make WordPress Core

Opened 5 years ago

Last modified 4 years ago

#48436 assigned defect (bug)

Media: fix the layout of Gallery settings in the media modal dialog

Reported by: afercia's profile afercia Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.9
Component: Media Keywords: has-screenshots
Focuses: ui Cc:


In WordPress 3.8, the gallery settings in the media modal right sidebar were well aligned:

The alignment broke pretty soon in WordPress 3.9, see [27487] / #26631. The CSS was changed to adjust the styling for the audio / video playlists settings but it broke the gallery details settings:

Screenshot from WordPress 3.9:

That's because the playlist settings are not intended to be aligned in two "columns":

The gallery settings are fully operable, so this is just a minor visual glitch.

Regardless, the layout is broken since March 2014 and still needs a fix on current trunk, even after the many changes to the media modal form controls markup and CSS, see [45499] / #47122.

Change History (6)

#1 follow-up: @afercia
5 years ago

  • Keywords needs-design-feedback added

It appears this CSS ruleset:

.collection-settings .setting span {
    min-width: inherit;

is no longer necessary. Removing it would restore the "two columns" layout illustrated in the first screenshot above. The collection-settings selector is only used for galleries and playlists settings in the right sidebar, see the templates gallery-settings and playlist-settings. Removing that min-width: inherit won't affect anything else.

However, instead of restoring the two columns. I'd like to propose to stack the labels and form controls vertically (except for the checkbox). Two columns in a so limited space within the right sidebar proved to be problematic especially with longer translations.

#2 @afercia
5 years ago

  • Owner set to afercia
  • Status changed from new to assigned

This ticket was mentioned in Slack in #core-media by antpb. View the logs.

4 years ago

This ticket was mentioned in Slack in #design by estelaris. View the logs.

4 years ago

#5 in reply to: ↑ 1 @estelaris
4 years ago

  • Keywords needs-design-feedback removed

Does fixing the alignment would be enough to fix the bug?

There are too many considerations to move from two-columns to one-column and perhaps you should open another ticket for that feature.

#6 @afercia
4 years ago

  • Owner afercia deleted
Note: See TracTickets for help on using tickets.