Context Navigation

← Previous Ticket
Next Ticket →

#48441 closed defect (bug) (fixed)

Parameters differ between instances of tiny_mce_plugins filter

Reported by:	johnbillion	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	5.4
Component:	Editor	Version:
Severity:	normal	Keywords:	good-first-bug has-patch
Cc:		Focuses:	docs

Description

The tiny_mce_plugins filter is applied in two places, but with different parameters.

Attachments (2)

class-wp-editor.diff (546 bytes ) - added by djp424 7 years ago.: wp-includes/class-wp-editor.php changes
48441.diff (577 bytes ) - added by djp424 7 years ago.: wp-includes/class-wp-editor.php changes v2

Download all attachments as: .zip

Change History (7)

#1 @johnbillion
7 years ago

It looks like this should be updated to match the mce_buttons filters.

@djp424
7 years ago

Attachment class-wp-editor.diff added

wp-includes/class-wp-editor.php changes

@djp424
7 years ago

Attachment 48441.diff added

wp-includes/class-wp-editor.php changes v2

#2 @djp424
7 years ago

Keywords has-patch added; needs-patch removed

Is this what you were looking to do @johnbillion? It now matches what the other filters in the same file do.

Please ignore class-wp-editor.diff
48441.diff has the intended changes

Last edited 7 years ago by djp424 (previous) (diff)

This ticket was mentioned in Slack in #core by sergey. View the logs.

7 years ago

#4 @SergeyBiryukov
7 years ago

Milestone Awaiting Review → 5.4

#5 @SergeyBiryukov
7 years ago

Owner set to SergeyBiryukov
Resolution → fixed
Status new → closed

In 46737:

Editor: Pass $editor_id parameter to tiny_mce_plugins, mce_external_plugins, and mce_external_languages filters, for consistency with teeny_mce_plugins.

Document the classic-block value passed to various editor filters in wp_tinymce_inline_scripts().

Add missing @since entries for the existing $editor_id parameter in various filters.

Props djp424, johnbillion, SergeyBiryukov.
Fixes #48441.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#48441 closed defect (bug) (fixed)

Parameters differ between instances of tiny_mce_plugins filter

Description

Attachments (2)

Change History (7)

#1 @johnbillion 7 years ago

@djp424 7 years ago

@djp424 7 years ago

#2 @djp424 7 years ago

This ticket was mentioned in ​Slack in #core by sergey. ​View the logs. 7 years ago

#4 @SergeyBiryukov 7 years ago

#5 @SergeyBiryukov 7 years ago

Download in other formats:

#1 @johnbillion
7 years ago

@djp424
7 years ago

@djp424
7 years ago

#2 @djp424
7 years ago

This ticket was mentioned in Slack in #core by sergey. View the logs.

7 years ago

#4 @SergeyBiryukov
7 years ago

#5 @SergeyBiryukov
7 years ago