WordPress.org

Make WordPress Core

Opened 3 weeks ago

Closed 44 hours ago

#48441 closed defect (bug) (fixed)

Parameters differ between instances of tiny_mce_plugins filter

Reported by: johnbillion Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: Editor Keywords: good-first-bug has-patch
Focuses: docs Cc:
PR Number:

Attachments (2)

class-wp-editor.diff (546 bytes) - added by djp424 2 weeks ago.
wp-includes/class-wp-editor.php changes
48441.diff (577 bytes) - added by djp424 2 weeks ago.
wp-includes/class-wp-editor.php changes v2

Download all attachments as: .zip

Change History (7)

#1 @johnbillion
3 weeks ago

It looks like this should be updated to match the mce_buttons filters.

@djp424
2 weeks ago

wp-includes/class-wp-editor.php changes

@djp424
2 weeks ago

wp-includes/class-wp-editor.php changes v2

#2 @djp424
2 weeks ago

  • Keywords has-patch added; needs-patch removed

Is this what you were looking to do @johnbillion? It now matches what the other filters in the same file do.

Please ignore class-wp-editor.diff
48441.diff has the intended changes

Last edited 2 weeks ago by djp424 (previous) (diff)

This ticket was mentioned in Slack in #core by sergey. View the logs.


5 days ago

#4 @SergeyBiryukov
45 hours ago

  • Milestone changed from Awaiting Review to 5.4

#5 @SergeyBiryukov
44 hours ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 46737:

Editor: Pass $editor_id parameter to tiny_mce_plugins, mce_external_plugins, and mce_external_languages filters, for consistency with teeny_mce_plugins.

Document the classic-block value passed to various editor filters in wp_tinymce_inline_scripts().

Add missing @since entries for the existing $editor_id parameter in various filters.

Props djp424, johnbillion, SergeyBiryukov.
Fixes #48441.

Note: See TracTickets for help on using tickets.