WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #48451, comment 9


Ignore:
Timestamp:
11/03/2019 08:07:32 PM (2 weeks ago)
Author:
johnbillion
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #48451, comment 9

    initial v1  
    1 Chatted with Joe about this ^ at WCUS and we're in agreement that it's unsafe for an extension to assume that the image sizes array passed to this filter is complete, especially as it's called in different places in core for many reasons.
     1Chatted with Joe about this at WCUS and we're in agreement that it's unsafe for an extension to assume that the image sizes array passed to this filter is complete, especially as it's called in different places in core for many reasons.
    22
    33In addition to the points above, the change in the patch has potential to result in a situation where image size meta data has partially been generated and stored, but the final call to `wp_update_attachment_metadata()` never gets called due to memory allocation issue, which would result in an attachment with metadata that's made available but has never made its way through the `wp_update_attachment_metadata` filter. This is also the case in the interim while image sizes are being generated.