![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Changes between Initial Version and Version 1 of Ticket #48453, comment 3
- Timestamp:
- 10/29/2019 08:18:49 AM (7 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #48453, comment 3
initial v1 2 2 > ''This ticket was mentioned in [https://make.wordpress.org/chat/ Slack] in #core by azaozz. [https://wordpress.slack.com/archives/core/p1572303558428200 View the logs].'' 3 3 4 From my perspective, moving the "original" would only complicate things, and that is because currently (in 5.3-RC2 also) there is no information recorded in the database of it, no file path, no width/height, just nothing, and we rely on the directory mentioned in the metadata for the full size to identify it (or at least I could not find another way to do this). It will just become a nightmare to delete it or just use it to generate files as a fa ilback when something went wrong with the full size.4 From my perspective, moving the "original" would only complicate things, and that is because currently (in 5.3-RC2 also) there is no information recorded in the database of it, no file path, no width/height, just nothing, and we rely on the directory mentioned in the metadata for the full size to identify it (or at least I could not find another way to do this). It will just become a nightmare to delete it or just use it to generate files as a fallback when something went wrong with the full size. 5 5 6 6 From all my tests, the issue with the full-size naming happens only when the threshold kicks in, and the sub-sizes are not generated from the new full size generated, but from the original itself. … … 10 10 Why aren't the sub-sizes generated from the new full-size which is smaller and also the quality high enough as far as I could test? 11 11 12 Also, what is the point to keep the "original" when the threshold was applied? As far as I understand the process `image-2560.jpeg` can be easily renamed back after the real original file and the real original removed (this is never used as far as I can see in the code). If the code would to this switch, then I do not see a problem anymore for the naming of the sub-sizes, and also, the sub-sizes will generate faster, from a smaller file.12 Also, what is the point to keep the "original" when the threshold was applied? As far as I understand the process `image-2560.jpeg` can be easily renamed back after the real original file and the real original removed (this is never used as far as I can see in the code). If the code would do this switch, then I do not see a problem anymore for the naming of the sub-sizes, and also, the sub-sizes will generate faster, from a smaller file. 13 13 14 14 Did I get this right?
