WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #48453, comment 3


Ignore:
Timestamp:
10/29/2019 08:19:15 AM (15 months ago)
Author:
Iulia Cazan
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #48453, comment 3

    v1 v2  
    22> ''This ticket was mentioned in [https://make.wordpress.org/chat/ Slack] in #core by azaozz. [https://wordpress.slack.com/archives/core/p1572303558428200 View the logs].''
    33
    4 From my perspective, moving the "original" would only complicate things, and that is because currently (in 5.3-RC2 also) there is no information recorded in the database of it, no file path, no width/height, just nothing, and we rely on the directory mentioned in the metadata for the full size to identify it (or at least I could not find another way to do this). It will just become a nightmare to delete it or just use it to generate files as a fallback when something went wrong with the full size.
     4From my perspective, moving the "original" would only complicate things, and that is because currently (in 5.3-RC2 also) there is no information recorded in the database of it, no file path, no width/height, just nothing, and we rely on the directory mentioned in the metadata for the full size to identify it (or at least I could not find another way to do this). It will just become a nightmare to delete it or just use it to generate files as a fallback when something went wrong with the full-size.
    55
    66From all my tests, the issue with the full-size naming happens only when the threshold kicks in, and the sub-sizes are not generated from the new full size generated, but from the original itself.