Missing Yoda condition

[1naveengiri]

Yoda condition is missing at line
​https://github.com/WordPress/WordPress/blob/master/wp-admin/user-new.php#L66

Thanks

[1naveengiri]

​https://github.com/WordPress/WordPress/blob/master/wp-admin/update-core.php#L167
​https://github.com/WordPress/WordPress/blob/master/wp-admin/update-core.php#L255
​https://github.com/WordPress/WordPress/blob/master/wp-admin/update-core.php#L691
​https://github.com/WordPress/WordPress/blob/master/wp-admin/update-core.php#L742
​https://github.com/WordPress/WordPress/blob/master/wp-admin/post.php#L304
​https://github.com/WordPress/WordPress/blob/master/wp-admin/options.php#L336
​https://github.com/WordPress/WordPress/blob/master/wp-admin/ms-delete-site.php#L45
​https://github.com/WordPress/WordPress/blob/master/wp-admin/media.php#L72
​https://github.com/WordPress/WordPress/blob/master/wp-admin/media-upload.php#L36
​https://github.com/WordPress/WordPress/blob/master/wp-admin/media-upload.php#L84
​https://github.com/WordPress/WordPress/blob/master/wp-admin/install.php#L389

[alishankhan]

@1naveengiri Do we really need yoda conditions since it does not provide much advantage. But do take aways readiablity.

[1naveengiri]

​https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#yoda-conditions
Based on WP coding standards, Yes we need.

[alishankhan]

Replying to 1naveengiri:

​https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#yoda-conditions
Based on WP coding standards, Yes we need.

ohh.. Okay
Thanks

[Marcio Zebedeu]

Replying to alishankhan:

Replying to 1naveengiri:

​https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#yoda-conditions
Based on WP coding standards, Yes we need.

ohh.. Okay
Thanks

Is anyone working on this ticket?

[Marcio Zebedeu]

adding Yoda conditions

[Marcio Zebedeu]

adding Yoda conditions

[alishankhan]

Replying to Marcio Zebedeu:

Replying to alishankhan:

Replying to 1naveengiri:

​https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#yoda-conditions
Based on WP coding standards, Yes we need.

ohh.. Okay
Thanks

Is anyone working on this ticket?

yep I was, but no problem.Cheers!!

[alishankhan]

@marcio-zebedeu
Please rebase your diff.

[alishankhan]

Replying to alishankhan:

@marcio-zebedeu
Please rebase your diff.

okay no need,
48455.1.patch​ is already rebased.

[bookdude13]

Refreshing, added a couple more spots

[bookdude13]

@alishankhan sorry if I'm hijacking this ticket, I wanted to help out a bit with 5.4 and this was a good candidate :)

Refreshed patch, caught a couple more cases where this was happening. Just needs some testing and another set of eyes to verify that the switched variables aren't changing the logic.

Note that the patch was made with git diff --no-ext-diff master > 48455.2.patch. If a different command is needed for SVN compatibility let me know and I can refresh.

[SergeyBiryukov]

In 47218:

Coding Standards: Use Yoda conditions in some wp-admin files.

Props subrataemfluence, marcio-zebedeu, bookdude13, 1naveengiri, alishankhan.
Fixes #44365, #48455.

[SergeyBiryukov]

In 47220:

Coding Standards: Correct the get_plugin_page_hook() check in wp-admin/admin.php.

The condition is meant to check for a non-empty string, however get_plugin_page_hook() can return null, in which case the strict check doesn't work as expected.

Follow-up to [47218].

See #48455, #49222.