WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

#48467 closed defect (bug) (fixed)

Update broken library links in PHP docblocks

Reported by: mryoga Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: General Keywords: good-first-bug has-patch
Focuses: docs Cc:

Description

Update broken link

Attachments (1)

48467.diff (200.0 KB) - added by finchps 5 months ago.

Download all attachments as: .zip

Change History (14)

#1 in reply to: ↑ description @mryoga
5 months ago

Replying to mryoga:

Update broken link

my link pull request https://github.com/WordPress/WordPress/pull/441

#2 @desrosj
5 months ago

  • Focuses docs added
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

Hi @mryoga,

Thanks for this ticket, and welcome to Trac!

Are you able to create a proper patch for this one so it can be tested/verified? There are some pages in the WordPress Core Contributor Handbook that will help.

When you refresh, please make sure to avoid the extra white space changes that were included in a few files.

Moving to Future Release, but it can be moved to 5.4 once patched.

#3 @desrosj
5 months ago

  • Summary changed from Update broken link to Update broken library links in PHP docblocks

#4 @SergeyBiryukov
5 months ago

  • Keywords good-first-bug added

#5 @mryoga
5 months ago

when I scanned into the wordpress project I found a lot of broken links, like how I reported the problem

#6 @FinchPS
5 months ago

I'm going to try and make a patch on this for contributor day.

@finchps
5 months ago

#7 follow-up: @FinchPS
5 months ago

@mryoga thank you for this ticket and the PR you provided as it was very helpful.

This patch addresses only the PHP files linked in the original Github PR here: https://github.com/WordPress/WordPress/pull/441

For the other files, these should be changed upstream in the original repos. I'll go ahead and submit PRs to those as well, and update this ticket with those links as well. As they are accepted, they will update WP Core on subsequent builds.

#8 @spenserhale
5 months ago

  • Keywords has-patch added; needs-patch removed

This ticket was mentioned in Slack in #core by sergey. View the logs.


5 months ago

#10 @SergeyBiryukov
5 months ago

  • Milestone changed from Future Release to 5.4
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#11 in reply to: ↑ 7 @SergeyBiryukov
5 months ago

Replying to FinchPS:

This patch addresses only the PHP files linked in the original Github PR here: https://github.com/WordPress/WordPress/pull/441

For the other files, these should be changed upstream in the original repos. I'll go ahead and submit PRs to those as well, and update this ticket with those links as well. As they are accepted, they will update WP Core on subsequent builds.

Thanks for the patch! Just noting that PHPMailer is an external library too.

Looking at the original PR, only these files can be patched directly:

wp-admin/includes/class-wp-filesystem-ssh2.php
js/_enqueues/vendor/imgareaselect/jquery.imgareaselect.js

jquery.imgareaselect.js used to be an external library, but appears to be abandoned upstream and is treated as "adopted" in WordPress core.

Any changes to other libraries and components from the initial pull request should be submitted to the respective GitHub repositories:

#12 @SergeyBiryukov
5 months ago

In 46741:

Docs: Update broken source code link in imgAreaSelect jQuery plugin.

Props mryoga, finchps.
See #48467.

#13 @SergeyBiryukov
5 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 46742:

Docs: Update broken source code link in WP_Filesystem_SSH2 class.

Props mryoga, finchps.
Fixes #48467.

Note: See TracTickets for help on using tickets.