Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #48472, comment 1


Ignore:
Timestamp:
10/30/2019 07:16:02 PM (5 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #48472, comment 1

    initial v1  
    33There was a discussion and several regression reports in [https://wordpress.slack.com/archives/C02SX62S6/p1571924433208800?thread_ts=1571923948.199900&cid=C02SX62S6 #core-media on Slack].
    44
    5 The consensus was that a hook needs to be fired after an image is uploaded successfully and all sub-sizes were created. Before #47872 `wp_generate_attachment_metadata` was always fired in these cases. Firing it at the end of `wp_update_image_subsizes()` seems to make the most sense and is backwards compatible.
     5The consensus was that a hook needs to be fired after an image is uploaded successfully and all sub-sizes were created. Before #47872 `wp_generate_attachment_metadata` was always fired in these cases. Firing it at the end of `wp_update_image_subsizes()` (when new metadta was generated and additional image sub-sizes created) seems to make the most sense and is backwards compatible.