WordPress.org

Make WordPress Core

Opened 5 weeks ago

Last modified 10 days ago

#48491 reviewing enhancement

[Theme compatibility] WP/PHP compatibility tests for single site theme updates/activation

Reported by: afragen Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: Site Health Keywords: has-patch needs-testing dev-feedback early servehappy needs-copy-review has-screenshots
Focuses: administration Cc:
PR Number:

Description

As part of the WP/PHP version compatibility testing for themes, this ticket is directed towards theme updating and activation on a single site installation.

If the theme is not compatible with the currently running WP or PHP version, updating will be blocked. This also includes blocking theme activation for incompatible themes.

This addresses the themes.php and upgrade-core.php pages.

Attachments (7)

48491.diff (13.2 KB) - added by afragen 5 weeks ago.
screenshot_02.png (149.1 KB) - added by afragen 5 weeks ago.
screenshot_04.png (201.2 KB) - added by afragen 5 weeks ago.
screenshot_01.png (49.8 KB) - added by afragen 5 weeks ago.
48491.2.diff (13.2 KB) - added by afragen 5 weeks ago.
Precedence: API > readme.txt > style.css
48491.3.diff (14.2 KB) - added by afragen 5 weeks ago.
Disable 'Live Preview' button
48491.4.patch (11.1 KB) - added by afragen 5 weeks ago.
removed changes to class-wp-theme.php, now in #48515

Download all attachments as: .zip

Change History (19)

#1 @afragen
5 weeks ago

Still to do are tickets/patches for installing themes and multisite.

#2 @afragen
5 weeks ago

Related: #44592

#3 @SergeyBiryukov
5 weeks ago

  • Milestone changed from Awaiting Review to 5.4

@afragen
5 weeks ago

@afragen
5 weeks ago

@afragen
5 weeks ago

#4 @afragen
5 weeks ago

The screenshots screenshot_02.png, screenshot_04.png, and screenshot_01.png show an incompatible update.

I manually set the PHP requirement so it would fail.

Last edited 5 weeks ago by afragen (previous) (diff)

@afragen
5 weeks ago

This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.


5 weeks ago

@afragen
5 weeks ago

Precedence: API > readme.txt > style.css

#6 @afragen
5 weeks ago

Hmm, I think I need to deactivate the Live Preview button as it can be used to activate.

#7 @afragen
5 weeks ago

It is still possible, using the Customizer, to see updates and activate a non-compliant theme. I will need help with fixing this component.

#8 @afragen
5 weeks ago

  • Keywords has-screenshots added

@afragen
5 weeks ago

Disable 'Live Preview' button

#9 @afragen
5 weeks ago

It is my plan to clean up this a bit. My intent is to remove the changes to WP_Theme and put them in their own ticket/patch. This patch would be the first patch needed to be reviewed/committed as it will be required by all these subsequent tickets/patches.

That way this ticket doesn't need to be committed before any of the others. Hopefully this simplifies the testing.

@afragen
5 weeks ago

removed changes to class-wp-theme.php, now in #48515

#10 @SergeyBiryukov
13 days ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#11 @sathyapulse
10 days ago

@afragen I am not able to apply the patch in my local environment. Could you please regenerate the patch?

#12 @afragen
10 days ago

@sathyapulse it's likely because the patch was created against core.git.wordpress.org, not develop.git.wordpress.org.

Note: See TracTickets for help on using tickets.