Context Navigation

← Previous Ticket
Next Ticket →

#48505 closed defect (bug) (fixed)

Update TwentyTwenty with minor changes for RC4

Reported by:	williampatton	Owned by:	desrosj
Priority:	normal	Milestone:	5.3
Component:	Bundled Theme	Version:	5.3
Severity:	normal	Keywords:	has-patch commit dev-reviewed
Cc:		Focuses:

Description

This ticket contains some very minor (but important) last minute fixes for TwentyTwenty. It would be much better to release with these included.

A fix for broken 'Continue Reading' link.
A fix for missing touch events in submenu items of the main nav.
Add missing credits for _s theme.

Attachments (1)

48505.diff (5.5 KB ) - added by williampatton 7 years ago.

Download all attachments as: .zip

Change History (20)

#1 @johnbillion
7 years ago

Milestone Awaiting Review → 5.3

@williampatton
7 years ago

Attachment 48505.diff added

#2 @johnbillion
7 years ago

Keywords needs-patch added

#3 @davidbaumwald
7 years ago

Keywords has-patch added; needs-patch removed

#4 @desrosj
7 years ago

This looks fine to me! There are a few spacing changes that get fixed running composer format I can make before committing.

@williampatton can you confirm that is intentional to add the Underscores callout in the readme file?

#5 @williampatton
7 years ago

The callout for underscores there is intentionally placed. There is code incorporated from that theme as part of the menu JS code.

#6 @desrosj
7 years ago

Keywords commit added

Thanks!

For reference, previous Twenty Twenty tickets: #48110, #48386, #48450, #48293.

Last edited 7 years ago by desrosj (previous) (diff)

#7 @desrosj
7 years ago

Owner set to desrosj
Resolution → fixed
Status new → closed

In 46668:

Bundled Themes: Update Twenty Twenty.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC3, see https://github.com/WordPress/twentytwenty/compare/dea9290...c267289.

Props williampatton, poena, andersnoren.
See #48110, #48386, #48450, #48293.
Fixes #48505.

#8 @desrosj
7 years ago

Keywords dev-feedback added
Resolution fixed
Status closed → reopened

Reopening for backporting to 5.3.

This ticket was mentioned in Slack in #core by desrosj. View the logs.

7 years ago

#10 @SergeyBiryukov
7 years ago

Keywords dev-reviewed added; dev-feedback removed

Looks good to backport.

#11 @desrosj
7 years ago

Resolution → fixed
Status reopened → closed

In 46669:

Bundled Themes: Update Twenty Twenty.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC3, see https://github.com/WordPress/twentytwenty/compare/dea9290...c267289.

Props williampatton, poena, andersnoren.
See #48110, #48386, #48450, #48293.
Fixes #48505.

#12 @SergeyBiryukov
7 years ago

In 46701:

Bundled Themes: Update Twenty Twenty.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC4, see https://github.com/WordPress/twentytwenty/compare/c267289...898792b.

Props williampatton, poena, andersnoren, desrosj, schlessera, leprincenoir, alextran, aristath, b-07.
See #48110, #48386, #48450, #48505.
Fixes #48557.

#13 @SergeyBiryukov
7 years ago

In 46712:

Bundled Themes: Update Twenty Twenty.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC4, see https://github.com/WordPress/twentytwenty/compare/c267289...ab5fa23.

Reviewed by SergeyBiryukov.
Props williampatton, poena, andersnoren, desrosj, schlessera, leprincenoir, alextran, aristath, b-07, allancole, karmatosed, pierlo, joen, ianbelanger.
See #48110, #48386, #48450, #48505.
Merges [46701], [46702], [46711] to the 5.3 branch.
Fixes #48557.

#14 @SergeyBiryukov
7 years ago

In 46713:

Bundled Themes: Update Twenty Twenty.

Add a11y-friendly default text-colors when selecting a background-color.
Remove margins for the group block when a background-color is set.
Excluding pullquote block from width resize rules.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46711], see https://github.com/WordPress/twentytwenty/compare/ab5fa23...162edc0.

Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Fixes #48557.

#15 @SergeyBiryukov
7 years ago

In 46714:

Bundled Themes: Update Twenty Twenty.

Add a11y-friendly default text-colors when selecting a background-color.
Remove margins for the group block when a background-color is set.
Excluding pullquote block from width resize rules.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46711], see https://github.com/WordPress/twentytwenty/compare/ab5fa23...162edc0.

Reviewed by azaozz, SergeyBiryukov.
Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Merges [46713] to the 5.3 branch.
Fixes #48557.

#16 @SergeyBiryukov
7 years ago

In 46715:

Bundled Themes: Update Twenty Twenty.

Add .has-background excluding condition to wide and full group-blocks.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46714], see https://github.com/WordPress/twentytwenty/compare/162edc0...fa8c3fc.

Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Fixes #48557.

#17 @SergeyBiryukov
7 years ago

In 46716:

Bundled Themes: Update Twenty Twenty.

Add .has-background excluding condition to wide and full group-blocks.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46714], see https://github.com/WordPress/twentytwenty/compare/162edc0...fa8c3fc.

Reviewed by azaozz, SergeyBiryukov.
Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Merges [46715] to the 5.3 branch.
Fixes #48557.

#18 @SergeyBiryukov
7 years ago

In 46722:

Bundled Themes: Update Twenty Twenty.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46715], see https://github.com/WordPress/twentytwenty/compare/fa8c3fc...a9e73ab.

Props Anlino, karmatosed, williampatton, poena, joyously, ianbelanger, chetan200891.
See #48110, #48386, #48450, #48505, #48557.
Fixes #48571.

#19 @SergeyBiryukov
7 years ago

In 46723:

Bundled Themes: Update Twenty Twenty.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46715], see https://github.com/WordPress/twentytwenty/compare/fa8c3fc...a9e73ab.

Props Anlino, karmatosed, williampatton, poena, joyously, ianbelanger, chetan200891.
See #48110, #48386, #48450, #48505, #48557.
Merges [46722] to the 5.3 branch.
Fixes #48571.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#48505 closed defect (bug) (fixed)

Update TwentyTwenty with minor changes for RC4

Description

Attachments (1)

Change History (20)

#1 @johnbillion 7 years ago

@williampatton 7 years ago

#2 @johnbillion 7 years ago

#3 @davidbaumwald 7 years ago

#4 @desrosj 7 years ago

#5 @williampatton 7 years ago

#6 @desrosj 7 years ago

#7 @desrosj 7 years ago

#8 @desrosj 7 years ago

This ticket was mentioned in ​Slack in #core by desrosj. ​View the logs. 7 years ago

#10 @SergeyBiryukov 7 years ago

#11 @desrosj 7 years ago

#12 @SergeyBiryukov 7 years ago

#13 @SergeyBiryukov 7 years ago

#14 @SergeyBiryukov 7 years ago

#15 @SergeyBiryukov 7 years ago

#16 @SergeyBiryukov 7 years ago

#17 @SergeyBiryukov 7 years ago

#18 @SergeyBiryukov 7 years ago

#19 @SergeyBiryukov 7 years ago

Download in other formats:

#1 @johnbillion
7 years ago

@williampatton
7 years ago

#2 @johnbillion
7 years ago

#3 @davidbaumwald
7 years ago

#4 @desrosj
7 years ago

#5 @williampatton
7 years ago

#6 @desrosj
7 years ago

#7 @desrosj
7 years ago

#8 @desrosj
7 years ago

This ticket was mentioned in Slack in #core by desrosj. View the logs.

7 years ago

#10 @SergeyBiryukov
7 years ago

#11 @desrosj
7 years ago

#12 @SergeyBiryukov
7 years ago

#13 @SergeyBiryukov
7 years ago

#14 @SergeyBiryukov
7 years ago

#15 @SergeyBiryukov
7 years ago

#16 @SergeyBiryukov
7 years ago

#17 @SergeyBiryukov
7 years ago

#18 @SergeyBiryukov
7 years ago

#19 @SergeyBiryukov
7 years ago