#48505 closed defect (bug) (fixed)
Update TwentyTwenty with minor changes for RC4
Reported by: | williampatton | Owned by: | desrosj |
---|---|---|---|
Milestone: | 5.3 | Priority: | normal |
Severity: | normal | Version: | 5.3 |
Component: | Bundled Theme | Keywords: | has-patch commit dev-reviewed |
Focuses: | Cc: |
Description
This ticket contains some very minor (but important) last minute fixes for TwentyTwenty. It would be much better to release with these included.
- A fix for broken 'Continue Reading' link.
- A fix for missing touch events in submenu items of the main nav.
- Add missing credits for _s theme.
Attachments (1)
Change History (20)
#5
@
5 years ago
The callout for underscores there is intentionally placed. There is code incorporated from that theme as part of the menu JS code.
#7
@
5 years ago
- Owner set to desrosj
- Resolution set to fixed
- Status changed from new to closed
In 46668:
#8
@
5 years ago
- Keywords dev-feedback added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for backporting to 5.3.
This ticket was mentioned in Slack in #core by desrosj. View the logs.
5 years ago
Note: See
TracTickets for help on using
tickets.
This looks fine to me! There are a few spacing changes that get fixed running
composer format
I can make before committing.@williampatton can you confirm that is intentional to add the Underscores callout in the readme file?