WordPress.org

Make WordPress Core

Opened 13 months ago

Closed 4 months ago

Last modified 4 months ago

#48507 closed task (blessed) (fixed)

[Theme compatibility] WP/PHP compatibility tests for multisite updates

Reported by: afragen Owned by: SergeyBiryukov
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Site Health Keywords: has-patch needs-testing early servehappy has-screenshots needs-design-feedback commit dev-reviewed has-dev-note
Focuses: administration, multisite Cc:

Description

As part of #48491, this ticket is to monitor multisite theme updating. This ticket and patches assume #48491 committed.

If a theme is not compatible with the currently running WP or PHP version, updating will be blocked for multisite.

Attachments (4)

48507.diff (5.1 KB) - added by afragen 13 months ago.
screenshot_01.png (96.8 KB) - added by afragen 13 months ago.
48507.2.diff (4.6 KB) - added by afragen 10 months ago.
updated
48507.3.diff (1009 bytes) - added by pbiron 4 months ago.

Download all attachments as: .zip

Change History (35)

@afragen
13 months ago

#1 @afragen
13 months ago

Yes, I changed values while running to demonstrate the incompatibility.

#2 @afragen
12 months ago

  • Milestone changed from Awaiting Review to 5.4

#3 @SergeyBiryukov
12 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.


11 months ago

This ticket was mentioned in Slack in #core-site-health by clorith. View the logs.


10 months ago

This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.


10 months ago

#7 @afragen
10 months ago

Pinging @jorbin per our discussion at WCPHX.

@afragen
10 months ago

updated

#8 @afragen
10 months ago

Updated to cleanly apply patch.

#9 @Clorith
10 months ago

  • Milestone changed from 5.4 to 5.5

Moving this to the 5.5 milestone, as it's marked early, and we are one day away from beta for 5.4

#10 @afragen
9 months ago

  • Keywords needs-design-feedback added

This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.


8 months ago

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


8 months ago

This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.


7 months ago

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


7 months ago

#15 @afragen
7 months ago

  • Keywords needs-dev-note added

This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.


7 months ago

This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.


6 months ago

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


6 months ago

#19 @davidbaumwald
5 months ago

  • Milestone changed from 5.5 to Future Release

With 5.5 Beta 1 approaching, the time for early tickets has now passed, and this ticket is being moved to Future Release. If any maintainer or committer feels this can be quickly resolved for 5.5 or wishes to assume ownership of this ticket during a specific cycle, feel free to update the milestone accordingly.

#20 @afragen
5 months ago

  • Milestone changed from Future Release to 5.5

I think this can be easily reviewed and tested. As it is one part of the already committed tickets regarding theme WP/PHP compatibility, I think it really needs to be considered for 5.5.

Pinging @SergeyBiryukov

#21 @melchoyce
5 months ago

We talked about this in today's #design triage.

Can the second line of text be indented to match the first line of text?

Also, the copy sounds pretty technical, and doesn't have an explicit action attached to help people figure out how to fix the issue. Are we able to tell what doesn't match — either the WordPress version, or the PHP version, or both? That can help us write some text that helps people figure out what to do next.

#22 @SergeyBiryukov
5 months ago

  • Type changed from enhancement to task (blessed)

#23 @SergeyBiryukov
4 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 48660:

Themes: Display a message on Themes list table if a theme update requires a higher version of PHP or WordPress.

This applies to the Themes screen in Multisite network admin.

Props afragen, SergeyBiryukov.
Fixes #48507. See #48491.

@pbiron
4 months ago

#24 @pbiron
4 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

In 5.5-RC1 I'm getting a Undefined variable: compatible_php warning.

48507.3.diff corrects this by passing the correct param to is_php_version_compatible().

#25 @afragen
4 months ago

@pbiron's above issue should be fixed by his patch.

This ticket was mentioned in Slack in #core by pbiron. View the logs.


4 months ago

#27 @SergeyBiryukov
4 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 48689:

Themes: Pass correct variable to is_php_version_compatible() in wp_theme_update_row().

This applies to the Themes screen in Multisite network admin.

Follow-up to [48660].

Props pbiron, afragen.
Fixes #48507. See #48491.

#28 @SergeyBiryukov
4 months ago

  • Keywords commit added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backporting to the 5.5 branch after a second committer's review.

Last edited 4 months ago by SergeyBiryukov (previous) (diff)

#29 @peterwilsoncc
4 months ago

  • Keywords dev-reviewed added; dev-feedback removed

@SergeyBiryukov [48689] reviewed for backporting to 5.5, variable renamed correctly ✅

#30 @SergeyBiryukov
4 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 48690:

Themes: Pass correct variable to is_php_version_compatible() in wp_theme_update_row().

This applies to the Themes screen in Multisite network admin.

Follow-up to [48660].

Props pbiron, afragen.
Reviewed by peterwilsoncc, SergeyBiryukov.
Merges [48689] to the 5.5 branch.
Fixes #48507. See #48491.

#31 @justinahinon
4 months ago

  • Keywords has-dev-note added; needs-dev-note removed
Note: See TracTickets for help on using tickets.