WordPress.org

Make WordPress Core

Opened 8 months ago

Last modified 2 days ago

#48507 reviewing task (blessed)

[Theme compatibility] WP/PHP compatibility tests for multisite updates

Reported by: afragen Owned by: SergeyBiryukov
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Site Health Keywords: has-patch needs-testing dev-feedback early servehappy has-screenshots needs-design-feedback needs-dev-note
Focuses: administration, multisite Cc:

Description

As part of #48491, this ticket is to monitor multisite theme updating. This ticket and patches assume #48491 committed.

If a theme is not compatible with the currently running WP or PHP version, updating will be blocked for multisite.

Attachments (3)

48507.diff (5.1 KB) - added by afragen 8 months ago.
screenshot_01.png (96.8 KB) - added by afragen 8 months ago.
48507.2.diff (4.6 KB) - added by afragen 5 months ago.
updated

Download all attachments as: .zip

Change History (25)

@afragen
8 months ago

#1 @afragen
8 months ago

Yes, I changed values while running to demonstrate the incompatibility.

#2 @afragen
8 months ago

  • Milestone changed from Awaiting Review to 5.4

#3 @SergeyBiryukov
8 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.


6 months ago

This ticket was mentioned in Slack in #core-site-health by clorith. View the logs.


5 months ago

This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.


5 months ago

#7 @afragen
5 months ago

Pinging @jorbin per our discussion at WCPHX.

@afragen
5 months ago

updated

#8 @afragen
5 months ago

Updated to cleanly apply patch.

#9 @Clorith
5 months ago

  • Milestone changed from 5.4 to 5.5

Moving this to the 5.5 milestone, as it's marked early, and we are one day away from beta for 5.4

#10 @afragen
4 months ago

  • Keywords needs-design-feedback added

This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.


4 months ago

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


3 months ago

This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.


2 months ago

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


2 months ago

#15 @afragen
8 weeks ago

  • Keywords needs-dev-note added

This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.


7 weeks ago

This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.


5 weeks ago

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


4 weeks ago

#19 @davidbaumwald
2 weeks ago

  • Milestone changed from 5.5 to Future Release

With 5.5 Beta 1 approaching, the time for early tickets has now passed, and this ticket is being moved to Future Release. If any maintainer or committer feels this can be quickly resolved for 5.5 or wishes to assume ownership of this ticket during a specific cycle, feel free to update the milestone accordingly.

#20 @afragen
13 days ago

  • Milestone changed from Future Release to 5.5

I think this can be easily reviewed and tested. As it is one part of the already committed tickets regarding theme WP/PHP compatibility, I think it really needs to be considered for 5.5.

Pinging @SergeyBiryukov

#21 @melchoyce
7 days ago

We talked about this in today's #design triage.

Can the second line of text be indented to match the first line of text?

Also, the copy sounds pretty technical, and doesn't have an explicit action attached to help people figure out how to fix the issue. Are we able to tell what doesn't match — either the WordPress version, or the PHP version, or both? That can help us write some text that helps people figure out what to do next.

#22 @SergeyBiryukov
2 days ago

  • Type changed from enhancement to task (blessed)
Note: See TracTickets for help on using tickets.