#48507 closed task (blessed) (fixed)
[Theme compatibility] WP/PHP compatibility tests for multisite updates
Reported by: | afragen | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Site Health | Keywords: | has-patch needs-testing early servehappy has-screenshots needs-design-feedback commit dev-reviewed has-dev-note |
Focuses: | administration, multisite | Cc: |
Attachments (4)
Change History (35)
This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.
5 years ago
This ticket was mentioned in Slack in #core-site-health by clorith. View the logs.
5 years ago
This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.
5 years ago
#9
@
5 years ago
- Milestone changed from 5.4 to 5.5
Moving this to the 5.5 milestone, as it's marked early
, and we are one day away from beta for 5.4
This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.
5 years ago
This ticket was mentioned in Slack in #core by david.baumwald. View the logs.
5 years ago
This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.
5 years ago
This ticket was mentioned in Slack in #core by david.baumwald. View the logs.
5 years ago
This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.
5 years ago
This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.
5 years ago
This ticket was mentioned in Slack in #core by david.baumwald. View the logs.
5 years ago
#19
@
4 years ago
- Milestone changed from 5.5 to Future Release
With 5.5 Beta 1 approaching, the time for early
tickets has now passed, and this ticket is being moved to Future Release
. If any maintainer or committer feels this can be quickly resolved for 5.5 or wishes to assume ownership of this ticket during a specific cycle, feel free to update the milestone accordingly.
#20
@
4 years ago
- Milestone changed from Future Release to 5.5
I think this can be easily reviewed and tested. As it is one part of the already committed tickets regarding theme WP/PHP compatibility, I think it really needs to be considered for 5.5.
Pinging @SergeyBiryukov
#21
@
4 years ago
We talked about this in today's #design triage.
Can the second line of text be indented to match the first line of text?
Also, the copy sounds pretty technical, and doesn't have an explicit action attached to help people figure out how to fix the issue. Are we able to tell what doesn't match — either the WordPress version, or the PHP version, or both? That can help us write some text that helps people figure out what to do next.
#24
@
4 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
In 5.5-RC1 I'm getting a Undefined variable: compatible_php
warning.
48507.3.diff corrects this by passing the correct param to is_php_version_compatible()
.
This ticket was mentioned in Slack in #core by pbiron. View the logs.
4 years ago
#28
@
4 years ago
- Keywords commit added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for backporting to the 5.5 branch.
#29
@
4 years ago
- Keywords dev-reviewed added; dev-feedback removed
@SergeyBiryukov [48689] reviewed for backporting to 5.5, variable renamed correctly ✅
Yes, I changed values while running to demonstrate the incompatibility.