#4852 closed defect (bug) (invalid)
Incorrect grammar when author ends with an s
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | low | |
Severity: | trivial | Version: | 2.3 |
Component: | I18N | Keywords: | has-patch |
Focuses: | Cc: |
Description
The following code in the_author_link contains a small bug.
sprintf(__("Visit %s's website"), get_the_author())
If get_the_author returns something which ends with an s, for example Niels, the output is Visit Niels's website, but it should be Visit Niels' website.
Change History (5)
#2
@
18 years ago
Actually, that's only true for plural possessives, not just words ending with "s," so the singular author should be fine.
From the MLA Handbook For Writers of Research Papers :
2.2.2 To form the possessive of a singular noun, add an apostrophe and an s. . . . All singular proper nouns, including the names of persons and places, form their possessives in the same manner (Mars's wrath, Camus's novel, Kansas's weather, Dickens's popularity, Jones's batting average, but the Dickenses' economic problems, the Joneses' estate).
#3
@
18 years ago
The grammar is actually correct, as filosofo indicates above. Shouldn't this be set to invalid?
This ticket was mentioned in PR #1026 on WordPress/wordpress-develop by afragen.
4 years ago
#5
- Keywords has-patch added
Remove check in readme.txt file for Requires at least
and Requires PHP
headers in plugins and themes for validation. While these headers may be in the readme.txt files, they should be in the main plugin file and the theme's style.css file.
I do not believe it is incorrect grammar, but rather an issue of style and, as such, subjective.