WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #48522, comment 15


Ignore:
Timestamp:
11/26/2019 10:45:21 PM (18 months ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #48522, comment 15

    v1 v2  
    77> My main concern is that this change might not be the best way to go forward without doing proper DSSIM tests to make sure that there is no visible change in images with the new resample size.
    88
    9 Yeah, this is a possible solution but will need to ensure the image sub-sizes maintain best quality. This also seems the most complex of the three, and reducing the `$sample_factor` in a try/catch "loop" may be too "costly" in some cases.
     9Yeah, this is a possible solution but will need to ensure the image sub-sizes maintain best quality. This also seems the most complex of the three, and reducing the `$sample_factor` in a try/catch "loop" may be too "costly" in some cases.
     10
     11A possible variant would be to reduce the `$sample_factor` by a bit larger value and only a set number of times. Of course, this will need testing/experimenting and can be added in 5.4.
    1012
    1113> Error handle this.