Changes between Version 1 and Version 2 of Ticket #48529, comment 17
- Timestamp:
- 06/01/2020 11:16:47 AM (3 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #48529, comment 17
v1 v2 1 1 I applied a few changes with the latest patch version uploaded: 2 2 3 - renamed `text_domain` to `textdomain` and changed the default value to `null` to reflect the fact that it can be ommited3 - renamed `text_domain` to `textdomain` (seems to be preferred in WordPress core, https://github.com/WordPress/wordpress-develop/search?q=textdomain&unscoped_q=textdomain) and changed the default value to `null` to reflect the fact that it can be ommited 4 4 - removed all references to `styleVariations` to continue use `styles` that existed before 5 5 - updated the default value for `attributes` to `null` to make it work with the logic pointed by @aduth – we can change it later but I would prefer to keep it out of this ticket because it's very sensitive change 6 - updated `parent` to allow `null` value and make it the defau k- it makes it possible to distinguish between `[]` and `null` that can have different meanings as pointed in https://github.com/WordPress/gutenberg/pull/22695#issuecomment-635329233 by @aduth6 - updated `parent` to allow `null` value and make it the default - it makes it possible to distinguish between `[]` and `null` that can have different meanings as pointed in https://github.com/WordPress/gutenberg/pull/22695#issuecomment-635329233 by @aduth 7 7 - `example` is also sensible to `null` vs `[]` logic