WordPress.org

Make WordPress Core

Opened 23 months ago

Last modified 20 months ago

#48536 accepted enhancement

Allow cmd/ctrl-enter to submit comment forms in wp-admin

Reported by: david.binda Owned by: davidbaumwald
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Comments Keywords: has-patch needs-testing 2nd-opinion
Focuses: javascript, administration Cc:

Description

This is a follow-up on #41545 which says:

I think it'd be a nice enhancement for comment forms in both the admin and front end to submit this way.

However, the r45790 introducing the feature does so only for frontend. Submitting comment by pressing ctrl/cmd + 'enter' does not seem to be working in wp-admin.

It would be cool if the new feature could be added to wp-admin as well.

Attachments (3)

48536.diff​ (636 bytes) - added by davidbaumwald 22 months ago.
Updated with keypress
48536.2.diff​ (637 bytes) - added by davidbaumwald 20 months ago.
Refreshed patch
48536.3.diff​ (848 bytes) - added by davidbaumwald 20 months ago.

Download all attachments as: .zip

Change History (12)

#1 @SergeyBiryukov
23 months ago

  • Focuses administration added

This ticket was mentioned in ​Slack in #core by peterwilsoncc. ​View the logs.
22 months ago

#3 @ehtis
22 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.4

Thanks for the report @davidbinda!

That indeed appears to be an issue - for now setting it for 5.4.

#4 @davidbaumwald
22 months ago

  • Owner set to davidbaumwald
  • Status changed from new to accepted

#5 @davidbaumwald
22 months ago

  • Keywords has-patch needs-testing added; needs-patch removed

@davidbaumwald
22 months ago

Updated with keypress

@davidbaumwald
20 months ago

Refreshed patch

This ticket was mentioned in ​Slack in #core by david.baumwald. ​View the logs.
20 months ago

#7 @davidbaumwald
20 months ago

After some help from @garrett-eclipse, I'm updating the patch for WPCS and dropping the '10' keyCode.

@davidbaumwald
20 months ago

#8 @davidbaumwald
20 months ago

  • Keywords 2nd-opinion added

Revisiting the 10 keyCode I had in the original patch, this was to accommodate Chrome's quirk for the keypress event. See ​https://bugs.chromium.org/p/chromium/issues/detail?id=79407. I'm thinking the final patch should include this, and we should also re-open #41545 or create a new ticket. Marking for 2nd-opinion.

#9 @davidbaumwald
20 months ago

  • Milestone changed from 5.4 to Future Release

This ticket still needs a final direction, patch, and testing. With 5.4 Beta 1 landing tomorrow, this is being moved to Future Release. If any maintainer or committer feels this can be included in 5.4 or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

Note: See TracTickets for help on using tickets.