Twenty Twenty: Customizer option to show or hide author bio

[williampatton]

Consider adding an option to show/hide the author bio.

A PR exists with code for this one at the original repo which a patch can be generated from.

Issue: ​https://github.com/WordPress/twentytwenty/issues/524
PR: ​https://github.com/WordPress/twentytwenty/pull/525

CC: @acosmin

[nielslange]

@williampatton & @ianbelanger I challenged myself to create a patch without looking at @acosmin's proposed solution and the result is pretty close. Feel free to test it and give props to @acosmin for fixing this issue first. 😀

[acosmin]

@nielslange looks ok to me :)

[nielslange]

@ianbelanger This could technically be shipped with 5.3.1, right?

[dlh]

Do note that this patch will cause the author bio to be hidden on existing installations until someone goes into the Customizer and saves the default setting, I believe.

[nielslange]

Replying to dlh:

Do note that this patch will cause the author bio to be hidden on existing installations until someone goes into the Customizer and saves the default setting, I believe.

Good catch, David! I just added a default statement to get_theme_mod( 'show_author_bio', true ), which should do the trick. Would you mind running a quick test, to see if this adjustment fixes the issue you've mentioned?

[dlh]

That should do it, @nielslange!

It would be nice if the default value was centralized into a variable or constant and documented so that the separate uses with get_theme_mod() and WP_Customize_Setting stayed in sync. But I'm not sure where it would be best to try to do that in Twenty Twenty.

[nielslange]

It would be nice if the default value was centralized into a variable or constant and documented so that the separate uses with get_theme_mod() and WP_Customize_Setting stayed in sync. But I'm not sure where it would be best to try to do that in Twenty Twenty.

Isn't show_author_bio the centralized "variable" in this case, @dlh? I'm not sure I understand your question correctly here. 🤔

[dlh]

Sorry, I mean the value of true now being passed both as the $default to get_theme_mod() and the 'default' to WP_Customize_Setting. It would be easy for a future developer to change one in a patch without realizing the other should be changed to match, assuming that it's not just coincidence that they're the same now.

[ianbelanger]

This looks good, I tested the feature and it works as intended. I am going to mark it for commit, but I am not sure that we can get it in on a minor release. If we can, I will get t committed.

Thanks for the patch @nielslange and for testing @dlh

[ianbelanger]

In 46813:

Bundled Themes: Adds Customizer option to show or hide author bio Twenty Twenty.

This adds an option to the Customizer that allows you to turn the author bio on or off, sitewide.

Props williampatton, nielslange acosmin, dlh.
Fixes #48550.

[SergeyBiryukov]

In 46848:

Twenty Twenty: Adds Customizer option to show or hide author bio.

This adds an option to the Customizer that allows you to turn the author bio on or off, sitewide.

Props williampatton, nielslange, acosmin, dlh, ianbelanger.
Merges [46813] to the 5.3 branch.
Fixes #48550.

[SergeyBiryukov]

@ianbelanger After a commit to trunk, please don't forget to reopen the ticket for minor release consideration, and add the ​`fixed-major` keyword.

Otherwise the ticket stays on the 5.3.1 milestone, but the changes are not actually included in 5.3.1. Thanks! :)

[ianbelanger]

Thanks for the reminder @SergeyBiryukov. Do I need to do it on this ticket? Since it's already been backported.

[SergeyBiryukov]

Replying to ianbelanger:

Do I need to do it on this ticket? Since it's already been backported.

Just a note for the future :)