WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 4 months ago

#48552 closed defect (bug) (fixed)

Twenty Twenty: Add theme support for responsive embeds

Reported by: williampatton Owned by: ianbelanger
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.3
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

The theme does not opt-in to use core responsive embeds with a call to add_theme_support( 'responsive-embeds' );.

Without this call the facebook embed has sizing issues at some screen widths. There may be other issues as well. Adding the call may require CSS adjustments for other embeds.

https://github.com/WordPress/twentytwenty/issues/269

Attachments (2)

66097197-c472e100-e59d-11e9-8857-0ea39cec9480.png (98.0 KB) - added by williampatton 8 months ago.
48552.patch (643 bytes) - added by nielslange 8 months ago.

Download all attachments as: .zip

Change History (24)

#1 @ianbelanger
8 months ago

  • Keywords needs-testing needs-patch added
  • Milestone changed from Awaiting Review to 5.3.1

#2 @nielslange
8 months ago

@williampatton and @ianbelanger This seems to be a pretty low-hanging fruit to get my hands dirty on Trac and patches after living within GitHub for the previous weeks. I'm happy to work on this issue and will provide a patch later today.

#3 @williampatton
8 months ago

@nielslange that would be awesome! Try to enjoy your integration back to trac lol!

@nielslange
8 months ago

#4 @nielslange
8 months ago

  • Keywords has-patch added; needs-patch removed

@williampatton I just created https://core.trac.wordpress.org/attachment/ticket/48552/48552.patch. Let's see if I've done it correct! It's been a while that I created a patch. 😁

#5 @williampatton
8 months ago

Patch looks good to me and I was able to apply cleanly.

Let's get some testing on this done and then find someone that can commit it for next release if all looks good :)

One thing that came to mind is that we might need slightly tweaked styles to account for any new ones output by core. @nielslange you want to own this ticket since you already got the patch ready?

#6 @nielslange
8 months ago

@williampatton Yeah, happy to hear that my patch skills didn’t gave up on me! 😆

One thing that came to mind is that we might need slightly tweaked styles to account for any new ones output by core. @nielslange you want to own this ticket since you already got the patch ready?

Sure, I’m happy to take on ownership for this issue.

#7 @williampatton
8 months ago

  • Owner set to nielslange
  • Status changed from new to assigned

#8 @ianbelanger
8 months ago

  • Version set to 5.3

#9 @ianbelanger
7 months ago

@nielslange and @williampatton I actually tried adding this support during development on GitHub, but there were some adverse side effects when I did it. Mainly video embeds were not actually responsive after adding this support, where they were before adding it. I believe that this needs further testing before it can be committed to core.

#10 @nielslange
7 months ago

Thanks for mentioning this, @ianbelanger!

Do you still know under which conditions you tested this implementation during eth GitHub development? Was it an embedded YouTube video you tested this implementation with?

#11 @ianbelanger
7 months ago

@nielslange I believe it was YouTube and Vimeo embeds

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


7 months ago

#13 @ianbelanger
7 months ago

  • Milestone changed from 5.3.1 to 5.4

#14 @ianbelanger
6 months ago

I tested your patch @nielslange and still applies cleanly. It also seem to work with no ill-effects. Could you confirm that you are not seeing any issues and I'll get it committed. Thanks

#15 @ianbelanger
6 months ago

  • Keywords commit added

#16 @ianbelanger
5 months ago

  • Keywords needs-testing removed
  • Owner changed from nielslange to ianbelanger
  • Status changed from assigned to reviewing

#17 @ianbelanger
5 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47135:

Bundled Themes: Twenty Twenty add theme support for responsive embeds.

Adds the call to responsive-embed theme support in order to fix issues with facebook embeds not being responsive at certain screen widths.

Props williampatton, nielslange.
Fixes #48552.

#18 @ianbelanger
5 months ago

  • Keywords fixed-major added
  • Milestone changed from 5.4 to 5.3.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport

#19 @ianbelanger
5 months ago

In 47139:

Fixes PHPCS Introduced in [47135].

There was extra whitespace in the previous commit, this removes it.

See #48552

#20 @audrasjb
5 months ago

  • Keywords commit fixed-major removed
  • Milestone changed from 5.3.3 to 5.4
  • Resolution set to fixed
  • Status changed from reopened to closed

Hi,
As per yesterday’s devchat and previous discussions in the minor release squad, let's move all Bundled Themes tickets from milestone 5.3.3 to 5.4 as there is no plan for a 5.3.3 release for now (except if it's a security release, which may of course happen at any time).

#21 @ianbelanger
5 months ago

  • Keywords fixed-major added
  • Milestone changed from 5.4 to 5.3.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

Hi @audrasjb, this has already been committed and then reopened for backport, that is why it was in the 5.3.3 milestone and tagged with fixed-major. I am going to move it back into 5.3.3 and reopen. Thanks

#22 @audrasjb
4 months ago

  • Keywords fixed-major removed
  • Milestone changed from 5.3.3 to 5.4
  • Resolution set to fixed
  • Status changed from reopened to closed

Moving 5.3.3 Bundled Themes tickets back to milestone 5.4 as RC1 is approaching.
Please don't move them back to 5.3.3 :-)

Note: See TracTickets for help on using tickets.