WordPress.org

Make WordPress Core

Opened 9 days ago

Last modified 4 days ago

#48552 assigned defect (bug)

Twenty Twenty: Add theme support for responsive embeds

Reported by: williampatton Owned by: nielslange
Milestone: 5.3.1 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: needs-testing has-patch
Focuses: Cc:
PR Number:

Description

The theme does not opt-in to use core responsive embeds with a call to add_theme_support( 'responsive-embeds' );.

Without this call the facebook embed has sizing issues at some screen widths. There may be other issues as well. Adding the call may require CSS adjustments for other embeds.

https://github.com/WordPress/twentytwenty/issues/269

Attachments (2)

66097197-c472e100-e59d-11e9-8857-0ea39cec9480.png (98.0 KB) - added by williampatton 9 days ago.
48552.patch (643 bytes) - added by nielslange 4 days ago.

Download all attachments as: .zip

Change History (9)

#1 @ianbelanger
7 days ago

  • Keywords needs-testing needs-patch added
  • Milestone changed from Awaiting Review to 5.3.1

#2 @nielslange
5 days ago

@williampatton and @ianbelanger This seems to be a pretty low-hanging fruit to get my hands dirty on Trac and patches after living within GitHub for the previous weeks. I'm happy to work on this issue and will provide a patch later today.

#3 @williampatton
4 days ago

@nielslange that would be awesome! Try to enjoy your integration back to trac lol!

@nielslange
4 days ago

#4 @nielslange
4 days ago

  • Keywords has-patch added; needs-patch removed

@williampatton I just created https://core.trac.wordpress.org/attachment/ticket/48552/48552.patch. Let's see if I've done it correct! It's been a while that I created a patch. 😁

#5 @williampatton
4 days ago

Patch looks good to me and I was able to apply cleanly.

Let's get some testing on this done and then find someone that can commit it for next release if all looks good :)

One thing that came to mind is that we might need slightly tweaked styles to account for any new ones output by core. @nielslange you want to own this ticket since you already got the patch ready?

#6 @nielslange
4 days ago

@williampatton Yeah, happy to hear that my patch skills didn’t gave up on me! 😆

One thing that came to mind is that we might need slightly tweaked styles to account for any new ones output by core. @nielslange you want to own this ticket since you already got the patch ready?

Sure, I’m happy to take on ownership for this issue.

#7 @williampatton
4 days ago

  • Owner set to nielslange
  • Status changed from new to assigned
Note: See TracTickets for help on using tickets.