Twenty Twenty: Add theme support for responsive embeds

[williampatton]

The theme does not opt-in to use core responsive embeds with a call to add_theme_support( 'responsive-embeds' );.

Without this call the facebook embed has sizing issues at some screen widths. There may be other issues as well. Adding the call may require CSS adjustments for other embeds.

​https://github.com/WordPress/twentytwenty/issues/269

[nielslange]

@williampatton and @ianbelanger This seems to be a pretty low-hanging fruit to get my hands dirty on Trac and patches after living within GitHub for the previous weeks. I'm happy to work on this issue and will provide a patch later today.

[williampatton]

@nielslange that would be awesome! Try to enjoy your integration back to trac lol!

[nielslange]

@williampatton I just created https://core.trac.wordpress.org/attachment/ticket/48552/48552.patch. Let's see if I've done it correct! It's been a while that I created a patch. 😁

[williampatton]

Patch looks good to me and I was able to apply cleanly.

Let's get some testing on this done and then find someone that can commit it for next release if all looks good :)

One thing that came to mind is that we might need slightly tweaked styles to account for any new ones output by core. @nielslange you want to own this ticket since you already got the patch ready?

[nielslange]

@williampatton Yeah, happy to hear that my patch skills didn’t gave up on me! 😆

One thing that came to mind is that we might need slightly tweaked styles to account for any new ones output by core. @nielslange you want to own this ticket since you already got the patch ready?

Sure, I’m happy to take on ownership for this issue.

[ianbelanger]

@nielslange and @williampatton I actually tried adding this support during development on GitHub, but there were some adverse side effects when I did it. Mainly video embeds were not actually responsive after adding this support, where they were before adding it. I believe that this needs further testing before it can be committed to core.

[nielslange]

Thanks for mentioning this, @ianbelanger!

Do you still know under which conditions you tested this implementation during eth GitHub development? Was it an embedded YouTube video you tested this implementation with?

[ianbelanger]

@nielslange I believe it was YouTube and Vimeo embeds

[ianbelanger]

I tested your patch @nielslange and still applies cleanly. It also seem to work with no ill-effects. Could you confirm that you are not seeing any issues and I'll get it committed. Thanks

[ianbelanger]

In 47135:

Bundled Themes: Twenty Twenty add theme support for responsive embeds.

Adds the call to responsive-embed theme support in order to fix issues with facebook embeds not being responsive at certain screen widths.

Props williampatton, nielslange.
Fixes #48552.

[ianbelanger]

Reopening for backport

[ianbelanger]

In 47139:

Fixes PHPCS Introduced in [47135].

There was extra whitespace in the previous commit, this removes it.

See #48552

[audrasjb]

Hi,
As per yesterday’s devchat and previous discussions in the minor release squad, let's move all Bundled Themes tickets from milestone 5.3.3 to 5.4 as there is no plan for a 5.3.3 release for now (except if it's a security release, which may of course happen at any time).

[ianbelanger]

Hi @audrasjb, this has already been committed and then reopened for backport, that is why it was in the 5.3.3 milestone and tagged with fixed-major. I am going to move it back into 5.3.3 and reopen. Thanks

[audrasjb]

Moving 5.3.3 Bundled Themes tickets back to milestone 5.4 as RC1 is approaching.
Please don't move them back to 5.3.3 :-)