Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#48555 closed enhancement (fixed)

The meta tag "apple-touch-icon-precomposed" is deprecated

Reported by: khag7's profile khag7 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: minor Version:
Component: Customize Keywords: good-first-bug has-patch
Focuses: Cc:

Description

The meta tag apple-touch-icon-precomposed is inserted when a site icon is defined.

That tag name is deprecated in favor of apple-touch-icon.

A good example of why this matters is to run a Google Lighthouse report on any website using WordPress. Unless they have corrected this issue themselves, a warning is thrown for using this tag name.

This is a 2 second fix, just remove -precomposed from line 31531 of /wp-includes/general-template.php.

In the meantime, I've been using the following filter on all my sites:

add_filter( 'site_icon_meta_tags', function( $mt ){
	return str_replace ( '-precomposed', '', $mt);
});

Attachments (1)

48555.diff (570 bytes) - added by mukto90 5 years ago.
I've attached a patch

Download all attachments as: .zip

Change History (5)

#2 @SergeyBiryukov
5 years ago

  • Component changed from General to Customize
  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to 5.4

@mukto90
5 years ago

I've attached a patch

#3 @mukto90
5 years ago

  • Keywords has-patch added; needs-patch removed

#4 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 46698:

Customize: Remove the deprecated -precomposed suffix from apple-touch-icon link in wp_site_icon().

Props mukto90, khag7.
Fixes #48555.

Note: See TracTickets for help on using tickets.