WordPress.org

Make WordPress Core

Opened 8 days ago

Closed 7 days ago

Last modified 6 days ago

#48557 closed defect (bug) (fixed)

Twenty Twenty: Final version for release

Reported by: williampatton Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit dev-reviewed
Focuses: Cc:
PR Number:

Description

This ticket contains the final set of fixes that we would like to merge before the WP 5.3 release.

In short this contains fixes to:

  • color selections
  • focus styles
  • starter content
  • menu touch inputs
  • screen reader text missing spaces
  • default font display corrected to match what is used
  • table and column block css fixes.

All changes between last patch and this one can be seen here: https://github.com/WordPress/twentytwenty/commits/master?since=2019-11-07&until=2019-11-11

Attachments (4)

48557.diff (31.2 KB) - added by williampatton 8 days ago.
48557.2.diff (42.3 KB) - added by williampatton 7 days ago.
48557.3.diff (11.1 KB) - added by azaozz 7 days ago.
48557.4.diff (1.9 KB) - added by azaozz 7 days ago.

Download all attachments as: .zip

Change History (27)

@williampatton
8 days ago

#1 @SergeyBiryukov
8 days ago

  • Milestone changed from Awaiting Review to 5.3

#2 @SergeyBiryukov
7 days ago

For reference, previous Twenty Twenty tickets: #48110, #48386, #48450, #48505.

#3 @SergeyBiryukov
7 days ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 46701:

Bundled Themes: Update Twenty Twenty.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC4, see https://github.com/WordPress/twentytwenty/compare/c267289...898792b.

Props williampatton, poena, andersnoren, desrosj, schlessera, leprincenoir, alextran, aristath, b-07.
See #48110, #48386, #48450, #48505.
Fixes #48557.

#4 @SergeyBiryukov
7 days ago

  • Keywords has-patch commit dev-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for a second committer's review before merging to the 5.3 branch.

#5 @SergeyBiryukov
7 days ago

In 46702:

Twenty Twenty: Fix WPCS issue in [46701].

See #48557.

#6 follow-up: @williampatton
7 days ago

Hey @SergeyBiryukov, thank you for looking at this. It has been noted that there was one quite important aspect missing from this patch here and we are working to try and figure out the best fixes and way to merge it.

Is it appropriate to put a mini pause on this one and add on the other fixes we are working on or would it be preferable to make another ticket after this one? Ideally I think we should try to get everything into this single ticket rather than open any more.

The final thing that needs added is changes for nesting/group handling for the latest editor changes. It is quite important that we get those in and done right for this theme.

#7 in reply to: ↑ 6 @SergeyBiryukov
7 days ago

Replying to williampatton:

Is it appropriate to put a mini pause on this one and add on the other fixes we are working on or would it be preferable to make another ticket after this one? Ideally I think we should try to get everything into this single ticket rather than open any more.

Sounds good, let's handle it here.

#8 @karmatosed
7 days ago

Just noting @allancole is working on a group block fix to be included so that will need to happen as part of this.

This ticket was mentioned in Slack in #core-committers by sergey. View the logs.


7 days ago

@williampatton
7 days ago

#10 @williampatton
7 days ago

Patch 48557.2.diff contains additional CSS adjustments that ensure that group blocks work in expected ways.

Props should be granted to these names as they may not have been included already.

@allancole
@karmatosed
@pierlo
@joen

#11 @ianbelanger
7 days ago

The patch looks good to me @williampatton.

@SergeyBiryukov could you confirm and get this committed? Thanks

#12 @SergeyBiryukov
7 days ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 46711:

Twenty Twenty: Make CSS adjustments to account for the latest editor changes and ensure that group blocks work in expected ways.

Props williampatton, allancole, karmatosed, pierlo, joen, ianbelanger.
Fixes #48557.

#13 @SergeyBiryukov
7 days ago

In 46712:

Bundled Themes: Update Twenty Twenty.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC4, see https://github.com/WordPress/twentytwenty/compare/c267289...ab5fa23.

Reviewed by SergeyBiryukov.
Props williampatton, poena, andersnoren, desrosj, schlessera, leprincenoir, alextran, aristath, b-07, allancole, karmatosed, pierlo, joen, ianbelanger.
See #48110, #48386, #48450, #48505.
Merges [46701], [46702], [46711] to the 5.3 branch.
Fixes #48557.

@azaozz
7 days ago

#14 @azaozz
7 days ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Few more last fixes. In 48557.3.diff:

  • Add a11y friendly default text-colors when selecting a background-color.
  • Remove margins for the group block when a background-color is set.
  • Excluding pullquote block from width resize rules.

Props go to @karmatosed and @allancole :)

Last edited 7 days ago by azaozz (previous) (diff)

#15 @SergeyBiryukov
7 days ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 46713:

Bundled Themes: Update Twenty Twenty.

  • Add a11y-friendly default text-colors when selecting a background-color.
  • Remove margins for the group block when a background-color is set.
  • Excluding pullquote block from width resize rules.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46711], see https://github.com/WordPress/twentytwenty/compare/ab5fa23...162edc0.

Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Fixes #48557.

#16 @SergeyBiryukov
7 days ago

  • Keywords dev-reviewed added; dev-feedback removed

#17 @SergeyBiryukov
7 days ago

In 46714:

Bundled Themes: Update Twenty Twenty.

  • Add a11y-friendly default text-colors when selecting a background-color.
  • Remove margins for the group block when a background-color is set.
  • Excluding pullquote block from width resize rules.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46711], see https://github.com/WordPress/twentytwenty/compare/ab5fa23...162edc0.

Reviewed by azaozz, SergeyBiryukov.
Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Merges [46713] to the 5.3 branch.
Fixes #48557.

#18 @azaozz
7 days ago

In 48557.4.diff: same as In 48557.3.diff also add .has-background excluding condition to wide and full group-blocks.

@azaozz
7 days ago

#19 @azaozz
7 days ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Lets add this last bit too :)

#20 @SergeyBiryukov
7 days ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 46715:

Bundled Themes: Update Twenty Twenty.

  • Add .has-background excluding condition to wide and full group-blocks.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46714], see https://github.com/WordPress/twentytwenty/compare/162edc0...fa8c3fc.

Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Fixes #48557.

#21 @SergeyBiryukov
7 days ago

In 46716:

Bundled Themes: Update Twenty Twenty.

  • Add .has-background excluding condition to wide and full group-blocks.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46714], see https://github.com/WordPress/twentytwenty/compare/162edc0...fa8c3fc.

Reviewed by azaozz, SergeyBiryukov.
Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Merges [46715] to the 5.3 branch.
Fixes #48557.

#22 @SergeyBiryukov
6 days ago

In 46722:

Bundled Themes: Update Twenty Twenty.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46715], see https://github.com/WordPress/twentytwenty/compare/fa8c3fc...a9e73ab.

Props Anlino, karmatosed, williampatton, poena, joyously, ianbelanger, chetan200891.
See #48110, #48386, #48450, #48505, #48557.
Fixes #48571.

#23 @SergeyBiryukov
6 days ago

In 46723:

Bundled Themes: Update Twenty Twenty.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46715], see https://github.com/WordPress/twentytwenty/compare/fa8c3fc...a9e73ab.

Props Anlino, karmatosed, williampatton, poena, joyously, ianbelanger, chetan200891.
See #48110, #48386, #48450, #48505, #48557.
Merges [46722] to the 5.3 branch.
Fixes #48571.

Note: See TracTickets for help on using tickets.