#48557 closed defect (bug) (fixed)
Twenty Twenty: Final version for release
Reported by: | williampatton | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch commit dev-reviewed |
Focuses: | Cc: |
Description
This ticket contains the final set of fixes that we would like to merge before the WP 5.3 release.
In short this contains fixes to:
- color selections
- focus styles
- starter content
- menu touch inputs
- screen reader text missing spaces
- default font display corrected to match what is used
- table and column block css fixes.
All changes between last patch and this one can be seen here: https://github.com/WordPress/twentytwenty/commits/master?since=2019-11-07&until=2019-11-11
Attachments (4)
Change History (27)
#3
@
5 years ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 46701:
#4
@
5 years ago
- Keywords has-patch commit dev-feedback added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for a second committer's review before merging to the 5.3 branch.
#6
follow-up:
↓ 7
@
5 years ago
Hey @SergeyBiryukov, thank you for looking at this. It has been noted that there was one quite important aspect missing from this patch here and we are working to try and figure out the best fixes and way to merge it.
Is it appropriate to put a mini pause on this one and add on the other fixes we are working on or would it be preferable to make another ticket after this one? Ideally I think we should try to get everything into this single ticket rather than open any more.
The final thing that needs added is changes for nesting/group handling for the latest editor changes. It is quite important that we get those in and done right for this theme.
#7
in reply to:
↑ 6
@
5 years ago
Replying to williampatton:
Is it appropriate to put a mini pause on this one and add on the other fixes we are working on or would it be preferable to make another ticket after this one? Ideally I think we should try to get everything into this single ticket rather than open any more.
Sounds good, let's handle it here.
#8
@
5 years ago
Just noting @allancole is working on a group block fix to be included so that will need to happen as part of this.
This ticket was mentioned in Slack in #core-committers by sergey. View the logs.
5 years ago
#10
@
5 years ago
Patch 48557.2.diff contains additional CSS adjustments that ensure that group blocks work in expected ways.
Props should be granted to these names as they may not have been included already.
@allancole
@karmatosed
@pierlo
@joen
#11
@
5 years ago
The patch looks good to me @williampatton.
@SergeyBiryukov could you confirm and get this committed? Thanks
#14
@
5 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Few more last fixes. In 48557.3.diff:
- Add a11y friendly default text-colors when selecting a background-color.
- Remove margins for the group block when a background-color is set.
- Excluding pullquote block from width resize rules.
Props go to @karmatosed and @allancole :)
#18
@
5 years ago
In 48557.4.diff: same as In 48557.3.diff also add .has-background
excluding condition to wide and full group-blocks.
For reference, previous Twenty Twenty tickets: #48110, #48386, #48450, #48505.