WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #48565, comment 2


Ignore:
Timestamp:
11/11/2019 08:54:02 PM (2 years ago)
Author:
azeemhassni
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #48565, comment 2

    v1 v2  
    1 Yeah, I agree but I also think this should be addressed if possible because it doesn't feel good to call `__toString` directly since it meant be called by PHP?
     1Yeah, I agree but I also think this should be addressed if possible because it doesn't feel good to call `__toString` directly since it meant to be called by PHP?
    22
    33Though I don't feed really good about it but I suggest we should have a helper maybe called `wp_is_string` and replace `is_string` calls with that, If you think that's a good idea I will be more than happy to submit a patch.