#48566 closed defect (bug) (fixed)
Update readme txt file for all theme
Reported by: | dkarfa | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch commit dev-feedback |
Focuses: | Cc: |
Description
Update year
Attachments (2)
Change History (12)
#1
@
5 years ago
- Component changed from General to Bundled Theme
- Keywords has-patch added
- Milestone changed from Awaiting Review to 5.3
#2
follow-up:
↓ 5
@
5 years ago
- Keywords commit dev-feedback added
48566.diff includes the bump for Twenty Seventeen and a unit test.
#3
@
5 years ago
Looking at the file paths, Twenty Seventeen has README.txt
, while all the other themes have readme.txt
.
Twenty Seventeen's file might need to be renamed for consistency and for the unit test to pass on Unix systems.
#4
@
5 years ago
Hey @SergeyBiryukov
May I need to update also in src/wp-content/themes/twentynineteen/style-rtl.css for "Twenty Nineteen is based on Underscores https://underscores.me/, (C) 2012-2018 Automattic, Inc.
Underscores is distributed under the terms of the GNU GPL v2 or later."
#5
in reply to:
↑ 2
@
5 years ago
Cool
Replying to SergeyBiryukov:
48566.diff includes the bump for Twenty Seventeen and a unit test.
Note: See
TracTickets for help on using
tickets.
Good catch! Since it's a non-code change, and all the default themes are changing anyway, we can probably get this in 5.3, as a follow-up to [46676] / #48517.
We should also add a unit test for this, in the same way we check the year in
license.txt
since [28064].