WordPress.org

Make WordPress Core

Opened 12 months ago

Closed 12 months ago

Last modified 6 months ago

#48566 closed defect (bug) (fixed)

Update readme txt file for all theme

Reported by: dkarfa Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit dev-feedback
Focuses: Cc:

Description

Update year

Attachments (2)

48566.patch (4.5 KB) - added by dkarfa 12 months ago.
48566.diff (5.9 KB) - added by SergeyBiryukov 12 months ago.

Download all attachments as: .zip

Change History (12)

@dkarfa
12 months ago

#1 @SergeyBiryukov
12 months ago

  • Component changed from General to Bundled Theme
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 5.3

Good catch! Since it's a non-code change, and all the default themes are changing anyway, we can probably get this in 5.3, as a follow-up to [46676] / #48517.

We should also add a unit test for this, in the same way we check the year in license.txt since [28064].

#2 follow-up: @SergeyBiryukov
12 months ago

  • Keywords commit dev-feedback added

48566.diff includes the bump for Twenty Seventeen and a unit test.

#3 @SergeyBiryukov
12 months ago

Looking at the file paths, Twenty Seventeen has README.txt, while all the other themes have readme.txt.

Twenty Seventeen's file might need to be renamed for consistency and for the unit test to pass on Unix systems.

#4 @dkarfa
12 months ago

Hey @SergeyBiryukov
May I need to update also in src/wp-content/themes/twentynineteen/style-rtl.css for "Twenty Nineteen is based on Underscores https://underscores.me/, (C) 2012-2018 Automattic, Inc.
Underscores is distributed under the terms of the GNU GPL v2 or later."

#5 in reply to: ↑ 2 @dkarfa
12 months ago

Cool
Replying to SergeyBiryukov:

48566.diff includes the bump for Twenty Seventeen and a unit test.

#6 @SergeyBiryukov
12 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 46719:

Bundled Themes: Update copyright year in readme.txt.

Add a unit test to ensure the year stays up to date.

Props dkarfa, SergeyBiryukov.
Fixes #48566.

#7 @SergeyBiryukov
12 months ago

In 46720:

Bundled Themes: Update copyright year in readme.txt for Twenty Twelve and Twenty Twenty.

Follow-up to [46719].

See #48566.

#8 @SergeyBiryukov
12 months ago

In 46721:

Bundled Themes: Update copyright year in readme.txt.

Add a unit test to ensure the year stays up to date.

Props dkarfa, SergeyBiryukov.
Merges [46719] and [46720] to the 5.3 branch.
Fixes #48566.

#9 @whyisjake
6 months ago

In 47629:

Bundled Themes: Update copyright year in readme.txt.

Add a unit test to ensure the year stays up to date.

Extends [46721] to 2020 and the 5.3 branch.

Fixes #48566.

#10 @whyisjake
6 months ago

In 47630:

Bundled Themes: Update copyright year in readme.txt. - Revert [47629]

Reverts [47629] as the tests will be updated, rather then the themes.

Props peterwilsoncc, whyisjake.
Fixes #48566.

Note: See TracTickets for help on using tickets.