WordPress.org

Make WordPress Core

Opened 4 weeks ago

Closed 4 weeks ago

Last modified 4 weeks ago

#48566 closed defect (bug) (fixed)

Update readme txt file for all theme

Reported by: dkarfa Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit dev-feedback
Focuses: Cc:
PR Number:

Description

Update year

Attachments (2)

48566.patch (4.5 KB) - added by dkarfa 4 weeks ago.
48566.diff (5.9 KB) - added by SergeyBiryukov 4 weeks ago.

Download all attachments as: .zip

Change History (10)

@dkarfa
4 weeks ago

#1 @SergeyBiryukov
4 weeks ago

  • Component changed from General to Bundled Theme
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 5.3

Good catch! Since it's a non-code change, and all the default themes are changing anyway, we can probably get this in 5.3, as a follow-up to [46676] / #48517.

We should also add a unit test for this, in the same way we check the year in license.txt since [28064].

@SergeyBiryukov
4 weeks ago

#2 follow-up: @SergeyBiryukov
4 weeks ago

  • Keywords commit dev-feedback added

48566.diff includes the bump for Twenty Seventeen and a unit test.

#3 @SergeyBiryukov
4 weeks ago

Looking at the file paths, Twenty Seventeen has README.txt, while all the other themes have readme.txt.

Twenty Seventeen's file might need to be renamed for consistency and for the unit test to pass on Unix systems.

#4 @dkarfa
4 weeks ago

Hey @SergeyBiryukov
May I need to update also in src/wp-content/themes/twentynineteen/style-rtl.css for "Twenty Nineteen is based on Underscores https://underscores.me/, (C) 2012-2018 Automattic, Inc.
Underscores is distributed under the terms of the GNU GPL v2 or later."

#5 in reply to: ↑ 2 @dkarfa
4 weeks ago

Cool
Replying to SergeyBiryukov:

48566.diff includes the bump for Twenty Seventeen and a unit test.

#6 @SergeyBiryukov
4 weeks ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 46719:

Bundled Themes: Update copyright year in readme.txt.

Add a unit test to ensure the year stays up to date.

Props dkarfa, SergeyBiryukov.
Fixes #48566.

#7 @SergeyBiryukov
4 weeks ago

In 46720:

Bundled Themes: Update copyright year in readme.txt for Twenty Twelve and Twenty Twenty.

Follow-up to [46719].

See #48566.

#8 @SergeyBiryukov
4 weeks ago

In 46721:

Bundled Themes: Update copyright year in readme.txt.

Add a unit test to ensure the year stays up to date.

Props dkarfa, SergeyBiryukov.
Merges [46719] and [46720] to the 5.3 branch.
Fixes #48566.

Note: See TracTickets for help on using tickets.