Make WordPress Core

Opened 2 years ago

Closed 22 months ago

#48570 closed defect (bug) (fixed)

incorrect return type for check_parent_theme_filter

Reported by: diddledani Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch
Focuses: docs Cc:


In wp-admin/includes/class-theme-upgrader.php the return type for method check_parent_theme_filter is incorrectly set to type. Presumably this is a result of an IDE's docblock template not being filled-out fully when documenting the function leaving the placeholder type.

The attached patch sets the return type to bool to match the type of $install_result.

Attachments (1)

48570.patch (980 bytes) - added by diddledani 2 years ago.
Patch to set the return type to bool

Download all attachments as: .zip

Change History (5)

2 years ago

Patch to set the return type to bool

#1 @johnbillion
2 years ago

  • Component changed from General to Upgrade/Install
  • Milestone changed from Awaiting Review to 5.4
  • Version trunk deleted

#2 @SergeyBiryukov
2 years ago

  • Component changed from Upgrade/Install to Themes
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing
  • Version set to trunk

#3 @SergeyBiryukov
2 years ago

  • Component changed from Themes to Upgrade/Install
  • Version trunk deleted

#4 @SergeyBiryukov
22 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47057:

Docs: Correct @return type for Theme_Upgrader::check_parent_theme_filter().

Props diddledan.
Fixes #48570.

Note: See TracTickets for help on using tickets.