WordPress.org

Make WordPress Core

Opened 4 weeks ago

Last modified 4 weeks ago

#48570 reviewing defect (bug)

incorrect return type for check_parent_theme_filter

Reported by: diddledan Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch
Focuses: docs Cc:
PR Number:

Description

In wp-admin/includes/class-theme-upgrader.php the return type for method check_parent_theme_filter is incorrectly set to type. Presumably this is a result of an IDE's docblock template not being filled-out fully when documenting the function leaving the placeholder type.

The attached patch sets the return type to bool to match the type of $install_result.

Attachments (1)

48570.patch (980 bytes) - added by diddledan 4 weeks ago.
Patch to set the return type to bool

Download all attachments as: .zip

Change History (4)

@diddledan
4 weeks ago

Patch to set the return type to bool

#1 @johnbillion
4 weeks ago

  • Component changed from General to Upgrade/Install
  • Milestone changed from Awaiting Review to 5.4
  • Version trunk deleted

#2 @SergeyBiryukov
4 weeks ago

  • Component changed from Upgrade/Install to Themes
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing
  • Version set to trunk

#3 @SergeyBiryukov
4 weeks ago

  • Component changed from Themes to Upgrade/Install
  • Version trunk deleted
Note: See TracTickets for help on using tickets.