WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#48570 closed defect (bug) (fixed)

incorrect return type for check_parent_theme_filter

Reported by: diddledani Owned by: SergeyBiryukov
Priority: normal Milestone: 5.4
Component: Upgrade/Install Version:
Severity: normal Keywords: has-patch
Cc: Focuses: docs

Description

In wp-admin/includes/class-theme-upgrader.php the return type for method check_parent_theme_filter is incorrectly set to type. Presumably this is a result of an IDE's docblock template not being filled-out fully when documenting the function leaving the placeholder type.

The attached patch sets the return type to bool to match the type of $install_result.

Attachments (1)

48570.patch​ (980 bytes ) - added by diddledani 7 years ago.
Patch to set the return type to bool

Download all attachments as: .zip

Change History (5)

@diddledani
7 years ago

Patch to set the return type to bool

#1 @johnbillion
7 years ago

  • Component General → Upgrade/Install
  • Milestone Awaiting Review → 5.4
  • Version trunk

#2 @SergeyBiryukov
7 years ago

  • Component Upgrade/Install → Themes
  • Owner set to SergeyBiryukov
  • Status new → reviewing
  • Version → trunk

#3 @SergeyBiryukov
7 years ago

  • Component Themes → Upgrade/Install
  • Version trunk

#4 @SergeyBiryukov
7 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 47057:

Docs: Correct @return type for Theme_Upgrader::check_parent_theme_filter().

Props diddledan.
Fixes #48570.

Note: See TracTickets for help on using tickets.