WordPress.org

Make WordPress Core

Opened 3 weeks ago

Closed 12 days ago

#48592 closed defect (bug) (fixed)

About display of tag cloud widget

Reported by: tmatsuur Owned by: audrasjb
Milestone: 5.3.1 Priority: normal
Severity: normal Version: 5.3
Component: Editor Keywords: has-screenshots has-patch commit fixed-major
Focuses: ui Cc:
PR Number:

Description

The classic editor tag cloud is not displayed correctly.
Specifically, the line spacing between tags has increased, making usability worse.

In version 5.3, “#poststuff .inside .the-tagcloud” has been changed from media.css to edit.css.

At that time, the value of line-height has been changed from 18em to 18.

/wp-admin/css/media.css(5.2.4)

#poststuff .inside .the-tagcloud {
    margin: 5px 0 10px;
    padding: 8px;
    border: 1px solid #ddd;
    line-height: 1.8em;
    word-spacing: 3px;
}

/wp-admin/css/edit.css(5.3.0)

#poststuff .inside .the-tagcloud {
    margin: 5px 0 10px;
    padding: 8px;
    border: 1px solid #ddd;
    line-height: 1.8;
    word-spacing: 3px;
}

Setting the line-height value between 1.1 and 1.2 will resemble the traditional display.

Please adjust this value.

Attachments (7)

most used tags 5.3 vs 5.2.png (87.8 KB) - added by afercia 3 weeks ago.
WordPress 5.3 on the left vs. 5.2 on the right
Capture d’écran 2019-11-17 à 11.16.57.png (63.7 KB) - added by audrasjb 3 weeks ago.
Tagcloud with 1.2 line height
Capture d’écran 2019-11-17 à 11.17.44.png (62.4 KB) - added by audrasjb 3 weeks ago.
Tagcloud with 1.1 line height
48592.patch (333 bytes) - added by sathyapulse 2 weeks ago.
48592.patch
48592.1.diff (351 bytes) - added by Spaceshipone 2 weeks ago.
48592.1.patch (345 bytes) - added by sathyapulse 2 weeks ago.
48592.1.patch
48592.png (44.9 KB) - added by SergeyBiryukov 2 weeks ago.

Download all attachments as: .zip

Change History (16)

#1 @SergeyBiryukov
3 weeks ago

  • Milestone changed from Awaiting Review to 5.3.1

Introduced in [45483].

@afercia
3 weeks ago

WordPress 5.3 on the left vs. 5.2 on the right

#2 @afercia
3 weeks ago

  • Keywords has-screenshots added

@audrasjb
3 weeks ago

Tagcloud with 1.2 line height

@audrasjb
3 weeks ago

Tagcloud with 1.1 line height

#3 @audrasjb
3 weeks ago

  • Focuses ui added
  • Owner set to audrasjb
  • Status changed from new to accepted

Hi,

I tested both 1.2 and 1.1 values and I'd recommend 1.2 which is closer to the previous styles.
See screenshots above.

Here is the suggested patch on edit.css:

#poststuff .inside .the-tagcloud {
	margin: 5px 0 10px;
	padding: 8px;
	border: 1px solid #ddd;
	line-height: 1.2;
	word-spacing: 3px;
}

@sathyapulse
2 weeks ago

48592.patch

#4 @audrasjb
2 weeks ago

  • Keywords needs-refresh added

Thanks for the patch @sathyapulse
However, the patch doesn't apply cleanly.
You have to generate it from wordpress-develop.

Adding needs-refresh keyword.

@Spaceshipone
2 weeks ago

@sathyapulse
2 weeks ago

48592.1.patch

#5 @audrasjb
2 weeks ago

  • Keywords has-patch commit added; needs-refresh removed

Thanks @Spaceshipone @sathyapulse both of the last 48592.1 patch work on my side!
Thank you very much!

Adding commit keyword :-)

Last edited 2 weeks ago by audrasjb (previous) (diff)

@SergeyBiryukov
2 weeks ago

#6 @SergeyBiryukov
2 weeks ago

For reference, on 48592.png: the tag cloud in 5.2 (left) and with the proposed patch (right).

The one from 5.2 with fixed height (1.8em) looks a bit more balanced to me on lines with smaller font size, however the proposed one seems close enough, and is an improvement over the current styles. Should be good to go.

#7 @SergeyBiryukov
2 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 46758:

Editor: Improve the appearance of tag cloud in Tags meta box in classic editor.

Props sathyapulse, Spaceshipone, tmatsuur, audrasjb, afercia.
Fixes #48592.

#8 @SergeyBiryukov
2 weeks ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 5.3.1.

#9 @SergeyBiryukov
12 days ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 46775:

Editor: Improve the appearance of tag cloud in Tags meta box in classic editor.

Props sathyapulse, Spaceshipone, tmatsuur, audrasjb, afercia.
Merges [46758] to the 5.3 branch.
Fixes #48592.

Note: See TracTickets for help on using tickets.