Opened 5 years ago
Closed 5 years ago
#48597 closed defect (bug) (invalid)
class-wp-upgrader-skin.php 5.3 update
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | |
| Component: | Upgrade/Install | Keywords: | |
| Focuses: | Cc: |
Description
On line 145 the public function 'feedback' broke my site - I am using Ocean wp and and got errors and headers already sent due to the addition of ', ...$args' to the function declaration.
Warning: Declaration of QuietSkin::feedback($string) should be compatible with WP_Upgrader_Skin::feedback($string, ...$args) in /home/expatu5/public_html/wp-content/plugins/ocean-extra/includes/wizard/classes/QuietSkin.php on line 12
I have removed this from the code and all is back working.
This seems to be an oversight as '...$args' is the not to my understanding the correct way to declare args.
If I am incorrect please let me know how I should address this problem.
Regards.
Change History (2)
#2
@
5 years ago
- Component changed from Plugins to Upgrade/Install
- Milestone Awaiting Review deleted
- Resolution set to invalid
- Status changed from new to closed
Hi @jlchapmanbg, welcome to WordPress Trac! Thanks for the report.
It's an issue with the Ocean Extra plugin, which hasn't been updated for 5.3 yet.
The support forums have a workaround that could be applied for now.
The change to WP_Upgrader_Skin::feedback() was made in [46125], see WP 5.3: Introducing the spread operator for more details.
Hello @jlchapmanbg, Welcome to WordPress Trac!
It looks like the issue is about the plugin.
Fyi, in WordPress 5.3 the definition of WP_Upgrader_Skin::feedback method in wp-admin/includes/class-wp-upgrader-skin.php