Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#48597 closed defect (bug) (invalid)

class-wp-upgrader-skin.php 5.3 update

Reported by: jlchapmanbg Owned by:
Priority: normal Milestone:
Component: Upgrade/Install Version:
Severity: normal Keywords:
Cc: Focuses:

Description

On line 145 the public function 'feedback' broke my site - I am using Ocean wp and and got errors and headers already sent due to the addition of ', ...$args' to the function declaration.
Warning: Declaration of QuietSkin::feedback($string) should be compatible with WP_Upgrader_Skin::feedback($string, ...$args) in /home/expatu5/public_html/wp-content/plugins/ocean-extra/includes/wizard/classes/QuietSkin.php on line 12
I have removed this from the code and all is back working.
This seems to be an oversight as '...$args' is the not to my understanding the correct way to declare args.
If I am incorrect please let me know how I should address this problem.
Regards.

Change History (2)

#1 @dkarfa
7 years ago

  • Component General → Plugins

Hello @jlchapmanbg, Welcome to WordPress Trac!

It looks like the issue is about the plugin.

Fyi, in WordPress 5.3 the definition of WP_Upgrader_Skin::feedback method in wp-admin/includes/class-wp-upgrader-skin.php

#2 @SergeyBiryukov
7 years ago

  • Component Plugins → Upgrade/Install
  • Milestone Awaiting Review
  • Resolution → invalid
  • Status new → closed

Hi @jlchapmanbg, welcome to WordPress Trac! Thanks for the report.

It's an issue with the Ocean Extra plugin, which hasn't been updated for 5.3 yet.

The support forums have a ​workaround that could be applied for now.

The change to WP_Upgrader_Skin::feedback() was made in [46125], see ​WP 5.3: Introducing the spread operator for more details.

Note: See TracTickets for help on using tickets.