:active button color issue in all color schemes except for "Default"

[studiotwee]

hi, in the latest update of WP the buttons had had a thick outline, which is great in terms of a11y. what’s less succesful is the :active state when selected the Midnight color scheme in wp-admin. See attached video demonstrating the issue.

BTW it's fine on the default color scheme.

[studiotwee]

video demostrating the issue

[ellatrix]

First reported here: ​https://wordpress.org/support/topic/actively-pressed-buttons-are-1-color-and-cannot-be-read/.

[studiotwee]

The same issue is here with colorscheme Sunrise, Ectoplasma, Coffee, Blue and Ocean. It's on all color schemes, except for default.

[afercia]

Good catch @studiotwee, thank you.

[studiotwee]

Replying to afercia:

Good catch @studiotwee, thank you.

very welcome. Can you do me a favor and remove the mp4 link from my initial ticket? I didnt know I could upload files with my ticket, which, in hindsight, is a very logical thing to be able to do.

[afercia]

Done.

[audrasjb]

#48661 was marked as a duplicate.

[larrach]

patch1

[larrach]

Hi,
I made a patch. I created a new color variable from $text-color so the patch will work with possible future color schemes.
patch test on all color schemes.

[audrasjb]

Testing 48598.diff with the 4 first color schemes

[audrasjb]

Testing 48598.diff with the 3 last color schemes

[audrasjb]

Testing 48598.diff with the 3 last color schemes

[audrasjb]

Thanks @larrach, I tested the patch and it looks good on my side.

[afercia]

Thanks for the patch @larrach 👋

I'm not sure the background color change should be kept though. That was a mistake introduced in [46423]

Instead, I'd tend to think the :active style should be consistent with the Gutenberg one. There's an inconsistency in Gutenberg as well, as the style varies across the color schemes. I just created an issue, thinking there should be some quick design feedback. See ​https://github.com/WordPress/gutenberg/issues/18577

Note: I think we can't use a new variable, as alternate color schemes provided by plugins would miss the variable. To test, install this plugin: ​https://wordpress.org/plugins/admin-color-schemes/

[SergeyBiryukov]

Related: #48709

[azaozz]

(Adding couple more screenshots to better illustrate the issue.)

[audrasjb]

We addressed this ticket during today's bug scrub, and given the short timeframe for 5.3.1, the current feeling would be to solve the issue with the current patch and to take time for a more global change on secondary buttons.

[melchoyce]

Think between this and my patch in #48585 I've fixed this.

[SergeyBiryukov]

In 46817:

Accessibility: Administration: Correct active button color for the alternative color schemes.

Follow-up to [46815].

Props melchoyce, ryelle, larrach, audrasjb, studiotwee, afercia, azaozz.
Fixes #48598.

[SergeyBiryukov]

In 46818:

Accessibility: Administration: Correct active button color for the alternative color schemes.

Follow-up to [46815].

Props melchoyce, ryelle, larrach, audrasjb, studiotwee, afercia, azaozz.
Merges [46817] to the 5.3 branch.
Fixes #48598.

[audrasjb]

Patch refreshed

[audrasjb]

Ah great, thanks Sergey! :D

[desrosj]

This was detailed in the following developer note: ​https://make.wordpress.org/core/2019/12/10/alternate-color-schemes-changes-in-wordpress-5-3-1/.