WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #48599, comment 16


Ignore:
Timestamp:
11/14/2019 11:04:54 PM (6 years ago)
Author:
garrett-eclipse
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #48599, comment 16

    initial v1  
    11112. Not providing the `$position` on the `add_submenu_page` call also avoids this as it avoids the reordering code where count is called here - https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/plugin.php#L1393-L1412
    1212
    13 I've added [https://core.trac.wordpress.org/attachment/ticket/48599/48599.1.diff] to test this theory but would love someone with more experience with menus to review.
     13I've added [https://core.trac.wordpress.org/attachment/ticket/48599/48599.1.diff] to test this theory but would love someone with more experience with menus to review. In essence if it slips through the previous check because parent and menu slugs match then it checks if the `$submenu[ $parent_slug ]` is set.
    1414
    1515Thanks