Opened 5 years ago
Closed 5 years ago
#48607 closed defect (bug) (fixed)
Administration email verification box is too wide on large size desktop.
Reported by: | chetan200891 | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.5 | Priority: | normal |
Severity: | normal | Version: | 5.3 |
Component: | Site Health | Keywords: | has-screenshots 2nd-opinion has-patch |
Focuses: | ui, administration | Cc: |
Description
In 5.3, new feature implemented called "Administration email verification" but it's box is showing too wide on large desktop. I have attached screenshot.
Attachments (9)
Change History (24)
#3
@
5 years ago
- Keywords 2nd-opinion added; has-patch removed
Hi @chetan200891, thanks for the patch. Yes, a "sensible" max-width would be good there. However thinking it shouldn't be "locked" to a specific pixel width, perhaps?
Also thinking it looks pretty well on mobile at the moment (https://core.trac.wordpress.org/attachment/ticket/48607/Email-Verification-Mobile-Before.png), adding more padding on the sides doesn't make it more readable, etc. Perhaps @andraganescu may want to have a look :)
#5
follow-up:
↓ 12
@
5 years ago
I agree that it would make sense to give it a max width here, I think that giving it a max pixel width is probably the correct way to go here though, as it's not a lot of information and text, and monitors are getting quite wide, which would lead to a lot of whitespace inside the container in many cases.
It should be a reasonable max though, I think Email-Verification-Desktop-Before.png is slightly too wide, removing maybe 10-15% of the width there I think is the sweet spot for most languages ( Email-Verification-Desktop-After.png is a little bit too narrow for my taste ).
This ticket was mentioned in Slack in #core by chetan200891. View the logs.
5 years ago
#7
@
5 years ago
- Milestone changed from Awaiting Review to 5.5
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.
5 years ago
This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.
5 years ago
#12
in reply to:
↑ 5
@
5 years ago
Replying to Clorith:
I agree that it would make sense to give it a max width here, I think that giving it a max pixel width is probably the correct way to go
Yeah, you're right. Looking again, the first patch (fixed max-width) seems better. The only thing that might needs changing is the padding on mobile, thinking having a smaller padding may be better?
Created patch 48607.diff provide
max-width
to box.