WordPress.org

Make WordPress Core

Opened 5 months ago

Last modified 4 days ago

#48607 reviewing defect (bug)

Administration email verification box is too wide on large size desktop.

Reported by: chetan200891 Owned by: SergeyBiryukov
Milestone: 5.5 Priority: normal
Severity: normal Version: 5.3
Component: Site Health Keywords: has-screenshots 2nd-opinion
Focuses: ui, administration Cc:

Description

In 5.3, new feature implemented called "Administration email verification" but it's box is showing too wide on large desktop. I have attached screenshot.

Attachments (6)

Email-Verification-Desktop-Before.png (46.2 KB) - added by chetan200891 5 months ago.
Email-Verification-Mobile-Before.png (40.4 KB) - added by chetan200891 5 months ago.
48607.diff (499 bytes) - added by chetan200891 5 months ago.
Email-Verification-Desktop-After.png (46.2 KB) - added by chetan200891 5 months ago.
After applying patch. - Desktop
Email-Verification-Mobile-After.png (39.1 KB) - added by chetan200891 5 months ago.
After applying patch. - Mobile
48607.1.diff (299 bytes) - added by chetan200891 4 days ago.
Updated patch.

Download all attachments as: .zip

Change History (13)

@chetan200891
5 months ago

#1 @chetan200891
5 months ago

Created patch 48607.diff provide max-width to box.

@chetan200891
5 months ago

After applying patch. - Desktop

@chetan200891
5 months ago

After applying patch. - Mobile

#2 @chetan200891
5 months ago

  • Keywords has-patch added

#3 @azaozz
5 months ago

  • Keywords 2nd-opinion added; has-patch removed

Hi @chetan200891, thanks for the patch. Yes, a "sensible" max-width would be good there. However thinking it shouldn't be "locked" to a specific pixel width, perhaps?

Also thinking it looks pretty well on mobile at the moment (https://core.trac.wordpress.org/attachment/ticket/48607/Email-Verification-Mobile-Before.png), adding more padding on the sides doesn't make it more readable, etc. Perhaps @andraganescu may want to have a look :)

#4 @SergeyBiryukov
5 months ago

  • Component changed from General to Site Health

#5 @Clorith
4 months ago

I agree that it would make sense to give it a max width here, I think that giving it a max pixel width is probably the correct way to go here though, as it's not a lot of information and text, and monitors are getting quite wide, which would lead to a lot of whitespace inside the container in many cases.

It should be a reasonable max though, I think Email-Verification-Desktop-Before.png is slightly too wide, removing maybe 10-15% of the width there I think is the sweet spot for most languages ( Email-Verification-Desktop-After.png is a little bit too narrow for my taste ).

@chetan200891
4 days ago

Updated patch.

This ticket was mentioned in Slack in #core by chetan200891. View the logs.


4 days ago

#7 @SergeyBiryukov
4 days ago

  • Milestone changed from Awaiting Review to 5.5
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.