Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#48629 closed defect (bug) (fixed)

Admin list table invalid CSS property

Reported by: manikmist09's profile manikmist09 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.3
Component: Site Health Keywords: has-patch
Focuses: ui, administration, coding-standards Cc:

Description

since there is opacity so it should be rgba instead of rgb

Attachments (1)

48629.patch (1.1 KB) - added by manikmist09 3 years ago.

Download all attachments as: .zip

Change History (4)

@manikmist09
3 years ago

#1 @SergeyBiryukov
3 years ago

  • Component changed from Administration to Site Health
  • Milestone changed from Awaiting Review to 5.4

Introduced in [44973].

#2 @SergeyBiryukov
3 years ago

Per https://developer.mozilla.org/en-US/docs/Web/CSS/color_value:

Note: As of CSS Colors Level 4, rgba() is an alias for rgb(). In browsers that implement the Level 4 standard, they accept the same parameters and behave the same way.

Apparently this is not an error. When testing in Chrome, both rgba() and rgb() work as expected here.

However, I guess it still makes sense to make the change for consistency with the rest of admin styles.

#3 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 46744:

Administration: Switch rgb() CSS property for paused plugin error message in Plugins list table to rgba().

While technically correct as is, the latter is more consistent with other admin styles and causes less confusion.

Props manikmist09.
Fixes #48629.

Note: See TracTickets for help on using tickets.