Bug in get_comment function from wp-includes/comment.php

[BogdanGhervan]

In the get_comment function, this block of code:

$comment = (int) $comment;
if ( !isset($comment_cache[$comment]) ) {
	$_comment = $wpdb->get_row("SELECT * FROM $wpdb->comments WHERE comment_ID = '$comment' LIMIT 1");
	$comment_cache[$comment->comment_ID] = & $_comment;
}

Should change to:

$comment = (int) $comment;
if ( !isset($comment_cache[$comment]) ) {
	$_comment = $wpdb->get_row("SELECT * FROM $wpdb->comments WHERE comment_ID = '$comment' LIMIT 1");
	$comment_cache[$comment] = & $_comment;
}

$comment is an int, not an object, therefore the comment_ID property doesn't exist.

[westi]

Hmm i suspect the intention here was for it to be $_comment->comment_ID that the cache was set on.

I think we need to check that the comment actually existed before we set the cache as well.

[ryan]

That code was changed to use the object cache in [5666]