Twenty Twenty: please use wp_enqueue_style for the fonts

[markhowellsmead]

Please please use wp_enqueue_style for the fonts (not CSS @import), so that they can be dequeued by a Child Theme or Plugin. (In case the Child Theme or Plugin wants to use different fonts.)

[nielslange]

@markhowellsmead Where do you see @import statements for fonts?

[markhowellsmead]

Replying to nielslange:

@markhowellsmead Where do you see @import statements for fonts?

Sorry, my bad - they're directly-referenced srcs in @font-face statements.

​https://github.com/WordPress/twentytwenty/blob/master/style.css#L254

[nielslange]

Sorry, my bad - they're directly-referenced srcs in @font-face statements.

​https://github.com/WordPress/twentytwenty/blob/master/style.css#L254

Don't worry and thanks for clarifying this! 😉 I see what you mean now and will create a patch for that. If the patch gets accepted is another story though. 😁

[markhowellsmead]

👏

[Otto42]

I'm confused as to what the issue here is. If a child theme wants to use different fonts, it can do so simply by defining them as such in the child theme CSS.

[markhowellsmead]

Replying to Otto42:

I'm confused as to what the issue here is. If a child theme wants to use different fonts, it can do so simply by defining them as such in the child theme CSS.

This true, but the font files from the parent theme will still be loaded, which is a(n albiet minor) performance hit.

[poena]

I agree that non system fonts should be enqueued.
Though I should probably learn more about variable fonts before I open my mouth ;)

[ianbelanger]

#48922 was marked as a duplicate.