Opened 5 years ago
Closed 5 years ago
#48650 closed defect (bug) (fixed)
Clarify function descriptions for get_gmt_from_date() and get_date_from_gmt()
Reported by: | johnbillion | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.4 | Priority: | normal |
Severity: | normal | Version: | 1.2 |
Component: | Date/Time | Keywords: | has-patch |
Focuses: | Cc: |
Description
The descriptions for these functions don't make sense, which doesn't help developers who are trying to make use of them.
Attachments (1)
Change History (5)
#2
@
5 years ago
Looks good, one small thing is that I've been trying to move towards saying UTC, rather than GMT time zone in documentation.
While colloquially these are synonyms, speaking technically GMT is a different historical thing and what we actually use and operate with on PHP level is UTC.
I leave existing gmt
in code and we have it hardwired into API and database schema, but on documentation level I feel UTC is more appropriate to describe what is going on.
Note: See
TracTickets for help on using
tickets.
48650.diff is my proposed patch.
cc @rarst can you confirm that these descriptions are accurate please?