Opened 5 years ago
Closed 5 years ago
#48657 closed enhancement (fixed)
wp-signup page lacks a role="main"
Reported by: | SteelWagstaff | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.4 | Priority: | normal |
Severity: | normal | Version: | 5.3 |
Component: | Login and Registration | Keywords: | has-patch |
Focuses: | accessibility, multisite | Cc: |
Description
The wp-signup.php
page lacks a role="main"
landmark. According to w3c guidelines, each webpage should have one main landmark, designated by the role="main"
attribute. See https://www.w3.org/TR/wai-aria-practices/examples/landmarks/main.html. It seems to me that the existing container div <div class="mu_register wp-signup-container">
https://core.trac.wordpress.org/browser/trunk/src/wp-signup.php#L89 would be a good candidate to receive the role="main" designation in this case. Patch attached (this is my first time contributing, so happy to take instruction if any part of this could be improved).
Attachments (2)
Change History (11)
This ticket was mentioned in Slack in #accessibility by steelwagstaff. View the logs.
5 years ago
This ticket was mentioned in Slack in #accessibility by afercia. View the logs.
5 years ago
#4
@
5 years ago
- Milestone changed from Awaiting Review to 5.4
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
#5
@
5 years ago
For more context, we're adding a main role via javascript in our WP-based project currently: https://github.com/pressbooks/pressbooks/pull/1837 and would love to remove if this were done by WP core.
#6
follow-up:
↓ 8
@
5 years ago
- Keywords needs-refresh has-patch added
Hi, welcome to WordPress Trac and thanks for this ticket,
Good catch!
FYI, I can't apply the patch since it wasn't generated against trunk (wordpress-develop repository).
Adding a new patch below
Adds role="main" to existing container div on the wp-signup.php page