WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 2 months ago

#48679 closed enhancement (wontfix)

Twenty Twenty: Theme Color Picker for primary color

Reported by: grafruessel Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.3
Component: Bundled Theme Keywords: has-screenshots
Focuses: Cc:

Description

Hi there,

I can select a specific color for Background Color and Header & Footer Background Color.
But why can't I do that with the primary color?

It would be easier to set that specific color for menu and the link color.

Maybe someone can change this?

Thanks,
kind regards, Nikolai

Attachments (1)

de_twentytwenty_colorpicker.png (1.7 MB) - added by grafruessel 8 months ago.

Download all attachments as: .zip

Change History (13)

#1 @grafruessel
8 months ago

  • Summary changed from Twenty Twenty Color Picker for primary color to Twenty Twenty Theme Color Picker for primary color

#2 @JarretC
8 months ago

Hi, the Primary Color uses a slider to ensure that the color options available are in line with accessibility requirements regarding contrast between colors and what not. More specific information can be found on the Github for Twenty Twenty here:

https://github.com/WordPress/twentytwenty/issues/284#issuecomment-533822167

#3 @nielslange
8 months ago

  • Component changed from Themes to Bundled Theme
  • Severity changed from normal to minor
  • Summary changed from Twenty Twenty Theme Color Picker for primary color to Twenty Twenty: Theme Color Picker for primary color

@grafruessel On https://github.com/WordPress/twentytwenty/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aclosed+Color+Picker you can find discussions we had regarding the color picker for the Twenty Twenty theme, but the main discussion took place in https://github.com/WordPress/twentytwenty/issues/284. 😉

Version 0, edited 8 months ago by nielslange (next)

#4 follow-ups: @grafruessel
8 months ago

  • Resolution set to invalid
  • Status changed from new to closed

ok, I get this with the a11y.

But would it be possible to let primary color chosen by developer due to style guides and calculate the background and the rest for a11y reasons automatically?

For me primary color is more important than background or header and footer.

#5 in reply to: ↑ 4 @grafruessel
8 months ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

Replying to grafruessel:

ok, I get this with the a11y.

But would it be possible to let primary color chosen by developer due to style guides and calculate the background and the rest for a11y reasons automatically?

For me primary color is more important than background or header and footer.

#6 in reply to: ↑ 4 @nielslange
8 months ago

Replying to grafruessel:

But would it be possible to let primary color chosen by developer due to style guides and calculate the background and the rest for a11y reasons automatically?

For me primary color is more important than background or header and footer.

That would indeed be possible and I like the idea of having the primary colour selectable and the background colour will be selected automatically based on the selected primary colour. I wonder why we didn't come up with that idea during the development of the Twenty Twenty theme. 🤔

cc: @anlino, @aristath, @williampatton, @ianbelanger, @poena

#7 @joyously
8 months ago

I wonder why we didn't come up with that idea during the development of the Twenty Twenty theme.

I thought of it, but I didn't look into how the color stuff was computed until too late to change things. Besides, the background color is much more visible everywhere, so being able to set that exactly makes more sense.

#8 @JarretC
8 months ago

While I don't agree with the current configuration as it is (site owners should be able to choose whatever color combinations they want whether accessible or not) I don't think adjusting both the background color and header/footer colors off of the primary color works either.

Both the background color and header/footer colors can be set with hex values. This allows site owners to use specific colors to configure their site as they see fit. Having the primary color value modify the background/header/footer color values is going to cause a lot of confusion. Modifying the background/header/footer colors has a larger effect on the overall look of the site so I imagine that users would be in for quite a surprise to have those colors changed without their consent.

#9 @jurjendevries
8 months ago

I had the same issue because I was adding a child theme. Then the colors have been reset and now I am not able to choose exactly the same color anymore. I can understand the contrast accessibility requirements, but make it have a better user experience for the site admin as well by given HEX fields and so, and then give feedback of the chosen color does match the criteria. For example as Yoast does with a visual color feedback if the given SEO words will work.

Thanks & keep up the good work

#10 @ianbelanger
7 months ago

  • Focuses css removed
  • Severity changed from minor to normal

#11 @Lynzaddy
2 months ago

I'm understanding all I'm reading and the customer likes the slider. Their question though...how do we choose black? The brand we are working with is black and white. We can't find a way to just make the nav links black without CSS. This is a multisite and users won't have that knowledge. We can explain the accessibility portion, but can someone help with just black?

#12 @ianbelanger
2 months ago

  • Keywords 2nd-opinion removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from reopened to closed

Hi @Lynzaddy,

The only way to currently do this in Twenty Twenty would be by using custom CSS. However, there is a plugin https://wordpress.org/plugins/options-for-twenty-twenty/ which allows you to choose a specific color, instead of using the color slider.

I am going to close this ticket for now, as there are no plans to change the way the color options work. If you feel that this should be reopened, please feel free to reopen the conversation.

Note: See TracTickets for help on using tickets.