Make WordPress Core

Opened 19 years ago

Closed 19 years ago

Last modified 12 years ago

#4869 closed defect (bug) (fixed)

Core update notification is displayed for all user levels

Reported by: johnbillion Owned by:
Priority: normal Milestone: 2.3
Component: Administration Version: 2.3
Severity: normal Keywords: dev-reviewed
Cc: Focuses:

Description

Every user of the admin panel sees the core update notification if there is an update available. It should only be displayed to users who have a sufficient capability. Not quite sure what though, maybe switch_themes?

Attachments (3)

4869.diff​ (551 bytes ) - added by johnbillion 19 years ago.
Only display core update notification to users with the switch_themes capability
4869-footer.diff​ (496 bytes ) - added by johnbillion 19 years ago.
Apply same logic for the admin footer
4869.2.diff​ (1.4 KB ) - added by johnbillion 19 years ago.
Replaces 2 previous patches, Check for manage_options capability, advise unpriv'd users to notify site admin, fix indentation

Download all attachments as: .zip

Change History (12)

@johnbillion
19 years ago

Only display core update notification to users with the switch_themes capability

#1 @johnbillion
19 years ago

Patch to only display core update notification to users with the switch_themes capability.

@johnbillion
19 years ago

Apply same logic for the admin footer

#2 @johnbillion
19 years ago

Patch for footer too. Just display the version number.

#3 @Viper007Bond
19 years ago

manage_options is another option.

#4 follow-up: @markjaquith
19 years ago

What if the administrator infrequently logs in? Authors who don't have FTP/SSH access could tell the administrator of the message, hastening the upgrade. We could to the manage_options test and to unpriv'd users say "Please notify the site administrator"

#5 @foolswisdom
19 years ago

  • Milestone → 2.3
  • Priority high → normal

@johnbillion
19 years ago

Replaces 2 previous patches, Check for manage_options capability, advise unpriv'd users to notify site admin, fix indentation

#6 in reply to: ↑ 4 @johnbillion
19 years ago

Replying to markjaquith:
Excellent point Mark. Patch refreshed.

#7 @westi
19 years ago

  • Keywords dev-reviewed added

+1 This looks good.

#8 @markjaquith
19 years ago

  • Resolution → fixed
  • Status new → closed

(In [5994]) Check manage_options for upgrade notification. Tailor message accordingly. Props johnbillion. fixes #4869

This ticket was mentioned in ​Slack in #core-flow by krogsgard. ​View the logs.


12 years ago

Note: See TracTickets for help on using tickets.