Make WordPress Core

Opened 17 years ago

Closed 17 years ago

Last modified 9 years ago

#4869 closed defect (bug) (fixed)

Core update notification is displayed for all user levels

Reported by: johnbillion's profile johnbillion Owned by:
Milestone: 2.3 Priority: normal
Severity: normal Version: 2.3
Component: Administration Keywords: dev-reviewed
Focuses: Cc:

Description

Every user of the admin panel sees the core update notification if there is an update available. It should only be displayed to users who have a sufficient capability. Not quite sure what though, maybe switch_themes?

Attachments (3)

4869.diff (551 bytes) - added by johnbillion 17 years ago.
Only display core update notification to users with the switch_themes capability
4869-footer.diff (496 bytes) - added by johnbillion 17 years ago.
Apply same logic for the admin footer
4869.2.diff (1.4 KB) - added by johnbillion 17 years ago.
Replaces 2 previous patches, Check for manage_options capability, advise unpriv'd users to notify site admin, fix indentation

Download all attachments as: .zip

Change History (12)

@johnbillion
17 years ago

Only display core update notification to users with the switch_themes capability

#1 @johnbillion
17 years ago

Patch to only display core update notification to users with the switch_themes capability.

@johnbillion
17 years ago

Apply same logic for the admin footer

#2 @johnbillion
17 years ago

Patch for footer too. Just display the version number.

#3 @Viper007Bond
17 years ago

manage_options is another option.

#4 follow-up: @markjaquith
17 years ago

What if the administrator infrequently logs in? Authors who don't have FTP/SSH access could tell the administrator of the message, hastening the upgrade. We could to the manage_options test and to unpriv'd users say "Please notify the site administrator"

#5 @foolswisdom
17 years ago

  • Milestone set to 2.3
  • Priority changed from high to normal

@johnbillion
17 years ago

Replaces 2 previous patches, Check for manage_options capability, advise unpriv'd users to notify site admin, fix indentation

#6 in reply to: ↑ 4 @johnbillion
17 years ago

Replying to markjaquith:
Excellent point Mark. Patch refreshed.

#7 @westi
17 years ago

  • Keywords dev-reviewed added

+1 This looks good.

#8 @markjaquith
17 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5994]) Check manage_options for upgrade notification. Tailor message accordingly. Props johnbillion. fixes #4869

This ticket was mentioned in Slack in #core-flow by krogsgard. View the logs.


9 years ago

Note: See TracTickets for help on using tickets.