#48713 closed enhancement (fixed)
Twenty Twenty: Social Icons Filter
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.5 | Priority: | normal |
Severity: | normal | Version: | 5.3 |
Component: | Bundled Theme | Keywords: | has-patch commit has-dev-note |
Focuses: | Cc: |
Description
Over on Github there was a filter set for the social icons where you could add more:
https://github.com/WordPress/twentytwenty/pull/770
However, I believe this was added after the code freeze so the feature was reverted for a later version. I wasn't able to find a ticket for that feature on Trac here so adding it to make sure it doesn't get lost.
Attachments (1)
Change History (15)
#7
@
9 months ago
- Keywords needs-dev-note added
- Milestone changed from Future Release to 5.5
Hi @acosmin,
Are you still interested in patching this? There have been a large handful of requests for different icons to be added, but it has definitely passed into plugin territory.
I would like to get this into the next version of Twenty Twenty, and accompany it with a dev note or equivalent documentation somewhere so that we can close new icon requests as wontfix
and direct folks to a way to add their own.
#10
@
9 months ago
- Keywords has-patch added; needs-patch removed
48713.diff copies over the filters in the original PR on GitHub linked above.
I removed the second and third parameters for the twentytwenty_svg_icons_social
and twentytwenty_svg_icons_{$group}
filters, though. They are called in two functions, but have different parameters available. get_social_link_svg()
has no color available, and get_svg()
has no $uri
. This would have resulted in inconsistent data being passed.
I also added a filter for the icon to domain mapping, and the color being used.
#11
@
9 months ago
- Keywords commit added
- Owner set to ianbelanger
- Status changed from new to reviewing
Reviewing for commit.
@acosmin As you created the PR for https://github.com/WordPress/twentytwenty/pull/770 could you create a patch for this issue or shall @JarretC or I do that on your behalf? 😀