Twenty Twenty: Social Icons Filter

[JarretC]

Over on Github there was a filter set for the social icons where you could add more:

​https://github.com/WordPress/twentytwenty/pull/770

However, I believe this was added after the code freeze so the feature was reverted for a later version. I wasn't able to find a ticket for that feature on Trac here so adding it to make sure it doesn't get lost.

[nielslange]

@acosmin As you created the PR for ​https://github.com/WordPress/twentytwenty/pull/770 could you create a patch for this issue or shall @JarretC or I do that on your behalf? 😀

[acosmin]

@nielslange I'll let you do it :) thank you

[nielslange]

Replying to acosmin:

@nielslange I'll let you do it :) thank you

Yeah, happy to implement it! 🙌

[SergeyBiryukov]

Related: #49034

[desrosj]

Hi @acosmin,

Are you still interested in patching this? There have been a large handful of requests for different icons to be added, but it has definitely passed into plugin territory.

I would like to get this into the next version of Twenty Twenty, and accompany it with a dev note or equivalent documentation somewhere so that we can close new icon requests as wontfix and direct folks to a way to add their own.

[desrosj]

#49034 was marked as a duplicate.

[desrosj]

Closed out the following tickets as wontfix in favor of adding a filter instead:

• #48905
• #50015
• #50302
• #50303

[desrosj]

48713.diff​ copies over the filters in the original PR on GitHub linked above.

I removed the second and third parameters for the twentytwenty_svg_icons_social and twentytwenty_svg_icons_{$group} filters, though. They are called in two functions, but have different parameters available. get_social_link_svg() has no color available, and get_svg() has no $uri. This would have resulted in inconsistent data being passed.

I also added a filter for the icon to domain mapping, and the color being used.

[ianbelanger]

Reviewing for commit.

[ianbelanger]

In 48180:

Bundled Themes: Twenty Twenty Social Icons Filter.

Adds a Social Icons Filter to Twenty Twenty that allows for new icons to be added to the theme by filter.

Props JarretC, nielslange, acosmin, desrosj.
Fixes #48713.

[SergeyBiryukov]

In 48181:

Twenty Twenty: Correct parameter types and @since version for twentytwenty_svg_icon_color filter.

Follow-up to [48180].

See #48713.

[justinahinon]

Dev note link: ​https://make.wordpress.org/core/2020/07/30/themes-field-guide-wordpress-5-5/