Make WordPress Core

Opened 5 years ago

Closed 3 years ago

#48722 closed defect (bug) (fixed)

Twenty Sixteen shows redundant borders for table in 5.3

Reported by: noyle's profile noyle Owned by: nielslange's profile nielslange
Milestone: 5.5 Priority: normal
Severity: normal Version: 5.3
Component: Bundled Theme Keywords: has-patch needs-testing has-screenshots
Focuses: css Cc:

Description

I don't know if Twenty Sixteen theme is still supported by WP 5.3 or if the theme problem should be reported here, but..

As of WP 5.3, the Gutenberg table block is inserted within a figure tag

<figure class="wp-block-table is-style-regular">
<table class=...
...
</figure>

but only bare table is inserted in WP prior 5.3. So the CSS for displaying a figure tag will add extra borders in top & left in WP 5.3 with the Twenty Sixteen theme.

See this link for example: https://noyle.home.blog/2019/11/19/19/.

There could be other blocks start getting a figure tag wrapper around themselves which will show a top and a left border for them. And the affected themes should not be limited to Twenty Sixteen.

Attachments (12)

48722.diff (1.4 KB) - added by nielslange 5 years ago.
#48722-editor-default-before.png (284.4 KB) - added by nielslange 5 years ago.
Editor - default style - before
#48722-editor-default-after.png (239.0 KB) - added by nielslange 5 years ago.
Editor - default style - after
#48722-editor-stripes-before.png (283.6 KB) - added by nielslange 5 years ago.
Editor - stripes style - before
#48722-editor-stripes-after.png (238.8 KB) - added by nielslange 5 years ago.
Editor - stripes style - after
#48722-post-default-before.png (179.5 KB) - added by nielslange 5 years ago.
Post - default style - before
#48722-post-default-after.png (178.8 KB) - added by nielslange 5 years ago.
Post - default style - after
#48722-post-stripes-before.png (177.5 KB) - added by nielslange 5 years ago.
Post - stripes style - before
#48722-post-stripes-after.png (178.2 KB) - added by nielslange 5 years ago.
Post - stripes style - after
Post 47 – A WordPress Site.png (27.2 KB) - added by noyle 5 years ago.
Tables-wordpress-5.3.png (24.9 KB) - added by noyle 5 years ago.
Fresh new install of WordPress 5.3 and applied the patch.
Tables-wordpress-5.3-admin.png (21.4 KB) - added by noyle 5 years ago.
Fresh new install of WordPress 5.3 and applied the patch. The look under admin.

Download all attachments as: .zip

Change History (24)

#1 @SergeyBiryukov
5 years ago

  • Component changed from Themes to Bundled Theme

#2 @nielslange
5 years ago

  • Keywords needs-patch added
  • Owner set to nielslange
  • Status changed from new to assigned

@nielslange
5 years ago

@nielslange
5 years ago

Editor - default style - before

@nielslange
5 years ago

Editor - default style - after

@nielslange
5 years ago

Editor - stripes style - before

@nielslange
5 years ago

Editor - stripes style - after

@nielslange
5 years ago

Post - default style - before

@nielslange
5 years ago

Post - default style - after

@nielslange
5 years ago

Post - stripes style - before

@nielslange
5 years ago

Post - stripes style - after

#3 @nielslange
5 years ago

  • Keywords has-patch needs-testing has-screenshots added; needs-patch removed
  • Milestone changed from Awaiting Review to 5.3.1

#4 @nielslange
5 years ago

@noyle Thank you very much for reporting this issue! Could you test is the patch fixed the reported issue on your end?

#5 @noyle
5 years ago

Thanks for looking into it and sorry for a separated reply.

I've applied patches for the two CSS files in my local site that is upgraded from 5.2. The block editor now shows correctly for strips style table. However in the front end, default style table now shows extra borders. Firefox calculates the border width as 3px for that <figure> block.

@noyle
5 years ago

Fresh new install of WordPress 5.3 and applied the patch.

@noyle
5 years ago

Fresh new install of WordPress 5.3 and applied the patch. The look under admin.

#6 @noyle
5 years ago

Hi @nielslange, I've uploaded two more screenshots from a new WordPress 5.3 install with provided patch, in Firefox. Both default table and strips table have undesired borders.

HTML codos are:

<figure class="wp-block-table"><table class=""><tbody><tr><td>default</td><td>table</td></tr><tr><td>row</td><td>two</td></tr><tr><td></td><td></td></tr><tr><td>last</td><td>row</td></tr></tbody></table></figure>

<figure class="wp-block-table is-style-stripes"><table class=""><tbody><tr><td>stripes</td><td>table</td></tr><tr><td>row</td><td>two</td></tr><tr><td></td><td></td></tr><tr><td>last</td><td>row</td></tr></tbody></table></figure>

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


5 years ago

#8 follow-up: @audrasjb
5 years ago

Hi,

@nielslange, as ticket owner and given 5.3.1 RC is scheduled for Tuesday, do you think the patch would make it for 5.3.1? Are you available to test the proposed patch? We'll need a decision on this ticket as soon as possible. Thanks!

#9 in reply to: ↑ 8 @nielslange
5 years ago

Hi,

@nielslange, as ticket owner and given 5.3.1 RC is scheduled for Tuesday, do you think the patch would make it for 5.3.1? Are you available to test the proposed patch? We'll need a decision on this ticket as soon as possible. Thanks!

Hello @audrasjb, while I cannot see a proposed patch, I can create a patch, based on @noyle's feedback. I'll do that later today.

#10 @ianbelanger
5 years ago

  • Milestone changed from 5.3.1 to 5.4

#11 @audrasjb
4 years ago

  • Milestone changed from 5.4 to Future Release

Hi,

With 5.4 Beta 3 approaching and the Beta period reserved for bugs introduced during the cycle, this is being moved to Future Release. If any maintainer or committer feels this should be included or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

#12 @sabernhardt
3 years ago

  • Milestone changed from Future Release to 5.5
  • Resolution set to fixed
  • Status changed from assigned to closed

Thank you for the report and your efforts!

This apparently was fixed in r48074 (ticket:50180) for WordPress 5.5.

Note: See TracTickets for help on using tickets.