Make WordPress Core

Opened 5 years ago

Closed 9 months ago

#48726 closed enhancement (invalid)

Twenty Twenty: Wrong Text Color for Background Color & Subtle Background when used as background color for blocks

Reported by: collet's profile collet Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.3
Component: Bundled Theme Keywords: dev-feedback close
Focuses: css Cc:

Description (last modified by sabernhardt)

To reproduce the issue:

  • In the customizer inside the Colors panel set the Background Color to #000, it will generate a white text color
  • In the editor, insert a block that supports background color (e.g. Paragraph) and select Background Color or Subtle Background as the background color using the color palette.

The text color is black instead of white, which makes the text unreadable.

The issue (front-end and editor) is caused by the CSS (which set the text to black) at the following lines:

Change History (7)

#1 @ianbelanger
5 years ago

  • Keywords needs-testing added

#2 @sabernhardt
4 years ago

  • Description modified (diff)

#3 @poena
15 months ago

  • Type changed from defect (bug) to enhancement

I can confirm that the automatic text color change is not implemented for the secondary, subtle background, and background colors.

It may look like it works for the secondary color, but that is because its default text color is white.

Attempts were made to solve this during development, but was deemed too complex:
https://github.com/WordPress/twentytwenty/pull/980

I am changing the type of this ticket from bug to enhancement since support for these colors was never implemented.

#4 @poena
15 months ago

  • Keywords needs-testing removed
  • Milestone changed from Awaiting Review to Future Release

#5 @karmatosed
10 months ago

  • Keywords dev-feedback added

#6 @karmatosed
9 months ago

  • Keywords close added

I would recommend this is closed due to being an enhancement and feature that was never added for this theme. As it has been something existed for a while and the focus on default themes is to be around bug fixing specifically.

This doesn't mean that in the future this couldn't be considered to be iterated on, just for now it means priorities should be on bugs. Thank you everyone.

#7 @karmatosed
9 months ago

  • Milestone Future Release deleted
  • Resolution set to invalid
  • Status changed from new to closed

I am going to follow through and close this. We can always reopen if needed or consider other approaches. Thank you everyone for your collaboration.

Note: See TracTickets for help on using tickets.