WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#48762 closed enhancement (wontfix)

Twenty Twenty: Add WooCommerce compatibility

Reported by: nielslange Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: close
Focuses: ui, css Cc:

Description

Reported by @businessbloomer on https://github.com/WordPress/twentytwenty/issues/1015.


I'm copying https://wordpress.org/support/topic/not-compatible-with-woocommerce-10/ here because I believe it's too important:

I love the new theme… but I’m quite surprised about these WooCommerce-related issues:

  • single product page looks like a blog post – author, published date and comments should not be there
  • single product page doesn’t take the full width (same applies to product archive pages)
  • single product page shows comments and “Leave a reply” but no WooCommerce reviews and “Leave a review” form
  • would be nice to have a cart menu icon
  • cart page & checkout page: shipping rate prices have a different format than the totals
  • checkout is missing the “shipping details” title

Hope this helps

Change History (6)

#1 @nielslange
6 months ago

  • Focuses ui css added

#2 @nielslange
6 months ago

  • Summary changed from Not compatible with WooCommerce (?) to Twenty Twenty: Add WooCommerce compatibility

#3 follow-up: @Clorith
6 months ago

  • Keywords close added

I'm actually not in agreement here, it shouldn't fall on the default theme to be styled for plugins (that would show unintentional favoritism towards one or more plugins, which just leads to unhappy times).

WooCommerce has historically added custom rules and styles for default themes, and can do so for Twenty Twenty as well if they wish to do that.

In light of that, I suggest closing this as wontfix (it sounds brutal, that's just the keyword name used by trac for closing a ticket without any intention of making changes).

#4 @dianeco
6 months ago

There's a work-in-progress PR in the WooCommerce repository to improve WC & Twenty Twenty compatibility. It should be included in the next WooCommerce release.

https://github.com/woocommerce/woocommerce/pull/25085

#5 @johnbillion
6 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

#6 in reply to: ↑ 3 @nielslange
6 months ago

Replying to Clorith:

I'm actually not in agreement here, it shouldn't fall on the default theme to be styled for plugins (that would show unintentional favoritism towards one or more plugins, which just leads to unhappy times).

WooCommerce has historically added custom rules and styles for default themes, and can do so for Twenty Twenty as well if they wish to do that.

In light of that, I suggest closing this as wontfix (it sounds brutal, that's just the keyword name used by trac for closing a ticket without any intention of making changes).

You're absolute correct, @Clorith. I shouldn't have opened this ticket here. 🤭


Replying to dianeco:

There's a work-in-progress PR in the WooCommerce repository to improve WC & Twenty Twenty compatibility. It should be included in the next WooCommerce release.

https://github.com/woocommerce/woocommerce/pull/25085

Thanks for adding the corresponding GitHub link to this issue, @dianeco! 🙏

Note: See TracTickets for help on using tickets.