WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#48777 closed defect (bug) (fixed)

get_preferred_from_update_core is missing a @since value

Reported by: zodiac1978 Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch
Focuses: docs Cc:

Description

I was using https://wpseek.com/pluginfilecheck/ to check a plugin and got a "Missing version information" error for get_preferred_from_update_core, so I think there is the @since line missing.

It looks like this was the commit introducing the function:
https://github.com/WordPress/WordPress/commit/e55a05453a270fe551073ab25daa375271c40c0c

so the correct line would be:

* @since 2.7.0

Attachments (1)

48777.patch (1.6 KB) - added by sathyapulse 3 months ago.
The patch make sure and adds the missing since version to all the functions introduced in the ticket #8023.

Download all attachments as: .zip

Change History (6)

@sathyapulse
3 months ago

The patch make sure and adds the missing since version to all the functions introduced in the ticket #8023.

#1 follow-up: @zodiac1978
3 months ago

Wow, that was fast @sathyapulse! I was just preparing the patch myself and then your comment was coming in. Thanks for the fast patch.

#2 in reply to: ↑ 1 @sathyapulse
3 months ago

Replying to zodiac1978:

Wow, that was fast @sathyapulse! I was just preparing the patch myself and then your comment was coming in. Thanks for the fast patch.

I thought you just reported the bug and not fixing it :-)

#3 @SergeyBiryukov
3 months ago

  • Component changed from General to Upgrade/Install
  • Focuses docs added
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 5.4
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#4 @SergeyBiryukov
3 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 46763:

Docs: Add missing @since tags for functions in wp-admin/includes/update.php.

Props sathyapulse, zodiac1978.
Fixes #48777.

#5 @SergeyBiryukov
3 months ago

In 46764:

Coding Standards: Fix WPCS issue in [46763].

See #48777.

Note: See TracTickets for help on using tickets.